CMake: fix empty string warnings - #7283
Merged
Merged
Conversation
Prior to this change, numerous warnings are issued by cmake:
CMake Warning:
Ignoring empty string ("") provided on the command line.
Signed-off-by: Keith W. Campbell <keithc@ca.ibm.com>
Contributor
Author
|
@babsingh Could I ask that you review this, please? |
Contributor
|
jenkins build all |
Contributor
|
OSX PR build failed due to a known and unrelated issue: #7181. |
babsingh
approved these changes
Mar 19, 2024
keithc-ca
added a commit
to keithc-ca/omr
that referenced
this pull request
Mar 21, 2024
This reverts commit 4ae6b18. Signed-off-by: Keith W. Campbell <keithc@ca.ibm.com>
babsingh
added a commit
that referenced
this pull request
Mar 21, 2024
Revert "CMake: fix empty string warnings" #7283
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this change, numerous warnings are issued by cmake:
For example, see https://openj9-jenkins.osuosl.org/job/Build_JDK21_aarch64_mac_Nightly/205.