Skip to content

Get the process start time - #7214

Merged
babsingh merged 1 commit into
eclipse-omr:masterfrom
singh264:omr_issues_7201
Jan 11, 2024
Merged

Get the process start time#7214
babsingh merged 1 commit into
eclipse-omr:masterfrom
singh264:omr_issues_7201

Conversation

@singh264

Copy link
Copy Markdown
Contributor

Get the process start time on linux, windows, osx, aix and
z/os.

Issue: #7201
Signed-off-by: Amarpreet Singh Amarpreet.A.Singh@ibm.com

@babsingh

Copy link
Copy Markdown
Contributor

jenkins build all

@singh264

singh264 commented Jan 2, 2024

Copy link
Copy Markdown
Contributor Author

@singh264

singh264 commented Jan 2, 2024

Copy link
Copy Markdown
Contributor Author

@tajila requesting your review.

@babsingh babsingh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preliminary review. Will do a thorough review once @tajila confirms that this implementation meets the requirements for #7201.

Comment thread fvtest/porttest/si.cpp
Comment thread fvtest/porttest/si.cpp
Comment thread port/win32/omrsysinfo.c Outdated
Comment thread port/unix/omrsysinfo.c Outdated
Comment thread port/common/omrsysinfo.c Outdated
Comment thread port/unix/omrsysinfo.c Outdated
Comment thread port/unix/omrsysinfo.c Outdated
Comment thread port/win32/omrsysinfo.c Outdated
Comment thread port/zos390/omrintrospect.h Outdated
Comment thread port/zos390/omrintrospect.h
@tajila

tajila commented Jan 3, 2024

Copy link
Copy Markdown
Contributor

@singh264

singh264 commented Jan 5, 2024

Copy link
Copy Markdown
Contributor Author

@singh264

singh264 commented Jan 5, 2024

Copy link
Copy Markdown
Contributor Author

@babsingh re-requesting your review.

@babsingh babsingh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolve the comments which have been addressed.

Comment thread fvtest/porttest/si.cpp Outdated
Comment thread fvtest/porttest/si.cpp
Comment thread port/aix/omrtime.c Outdated
Comment thread port/common/omrport.tdf Outdated
Comment thread port/common/omrport.tdf Outdated
Comment thread port/common/omrsysinfo.c Outdated
Comment thread port/unix/omrsysinfo.c Outdated
Comment thread port/unix/omrsysinfo.c Outdated
Comment thread port/unix/omrsysinfo.c
Comment thread port/unix/omrsysinfo.c Outdated
@singh264
singh264 force-pushed the omr_issues_7201 branch 3 times, most recently from 403d584 to 4849c60 Compare January 8, 2024 21:52
@singh264

Copy link
Copy Markdown
Contributor Author

@singh264

Copy link
Copy Markdown
Contributor Author

@babsingh re-requesting your review.

Comment thread port/unix/omrsysinfo.c Outdated
Comment thread port/win32/omrsysinfo.c Outdated
Get the process start time on linux, windows, osx, aix and
z/os.

Issue: eclipse-omr#7201
Signed-off-by: Amarpreet Singh <Amarpreet.A.Singh@ibm.com>
@singh264

Copy link
Copy Markdown
Contributor Author

@singh264

Copy link
Copy Markdown
Contributor Author

@babsingh re-requesting your review.

@babsingh

Copy link
Copy Markdown
Contributor

jenkins build all

@babsingh babsingh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only known and unrelated issues are seen in the PR builds:

@babsingh
babsingh merged commit 9d24613 into eclipse-omr:master Jan 11, 2024
Comment thread port/common/omrport.tdf
singh264 pushed a commit to singh264/openj9 that referenced this pull request Jan 24, 2024
Get the start time of the criu restore process, which is
the parent process of the restored java process.

Issue: eclipse-openj9#18598
Depends-on: eclipse-omr/omr#7214
Signed-off-by: Amarpreet Singh <Amarpreet.A.Singh@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants