Fix string literal conversion warnings in codegen, p, il, infra, optimizer - #7185
Merged
Merged
Conversation
maggietuttle
requested review from
0xdaryl,
Leonardo2718,
aviansie-ben,
mstoodle and
vijaysun-omr
as code owners
November 16, 2023 14:45
maggietuttle
force-pushed
the
constCharAnyTime
branch
from
November 22, 2023 15:57
29fd7aa to
a4e62df
Compare
maggietuttle
changed the title
maggietuttle
force-pushed
the
constCharAnyTime
branch
from
December 8, 2023 19:41
a4e62df to
629915b
Compare
hzongaro
reviewed
Dec 11, 2023
hzongaro
left a comment
hzongaro
left a comment
Contributor
There was a problem hiding this comment.
I think the changes look good overall. Just one question and a comment on typo. in some existing code. Thanks!
hzongaro
reviewed
Dec 11, 2023
maggietuttle
force-pushed
the
constCharAnyTime
branch
from
December 11, 2023 18:05
629915b to
de4ab65
Compare
maggietuttle
force-pushed
the
constCharAnyTime
branch
from
December 11, 2023 18:30
de4ab65 to
1ecb587
Compare
hzongaro
approved these changes
Dec 11, 2023
Contributor
|
Jenkins build all |
Contributor
|
It looks like a riscv test timed out. Rerunning. . . . Jenkins build riscv |
Fix string literal conversion warnings in compiler/codegen Signed-off-by: Dylan Tuttle <jdylantuttle@gmail.com>
Fix string literal conversion warnings in compiler/p Signed-off-by: Dylan Tuttle <jdylantuttle@gmail.com>
Fix string literal conversion warnings in compiler/il Signed-off-by: Dylan Tuttle <jdylantuttle@gmail.com>
maggietuttle
force-pushed
the
constCharAnyTime
branch
from
December 12, 2023 15:52
b0fb5d5 to
3abe74b
Compare
Contributor
|
Jenkins build all |
Contributor
|
Windows failure appears to be due to infrastructure issues. I'm not clear on the reason for the riscv failures, but I don't think they're related to this change. Rerunning both. Jenkins build win,riscv |
Contributor
|
Trying riscv once more Jenkins build riscv |
hzongaro
reviewed
Dec 13, 2023
Fix string literal conversion warnings in compiler/optimizer Signed-off-by: Dylan Tuttle <jdylantuttle@gmail.com>
maggietuttle
force-pushed
the
constCharAnyTime
branch
from
December 13, 2023 15:09
3abe74b to
4ea4731
Compare
Contributor
|
Jenkins build all |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work towards fixing AIX warnings about assigning string literals to non-const char pointers by adding 'const' qualifiers to some string variables and parameters (or worst case scenario, casting to
(char *)) in codegen, p, il, and optimizer.This PR contributes to (but does not close) eclipse-openj9/openj9#14859
This PR must be merged in coordination with eclipse-openj9/openj9#18465