We do not need disableOSRGuardsMerging to enforceVectorAPIExpansion - #6828
Merged
Conversation
Since we have made improvements to allow marking guards for the Vector JEP method does not kill fear, we no longer need to disable merging of OSR guards to enforce Vector API Expansion. Remove setting that option. Signed-off-by: Rahil Shah <rahil@ca.ibm.com>
Contributor
Author
|
With the changes in eclipse-openj9/openj9#16354 getting merged soon, we no longer need to set |
vijaysun-omr
approved these changes
Nov 28, 2022
Contributor
|
Jenkins build all |
Contributor
|
I think this PR (merged) eclipse-openj9/openj9#16206 already eliminates the need for disableOSRGuardsMerging. |
Contributor
|
Only failing test is the known/unrelated Power Linux LE failure. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we have made improvements to allow marking guards for the Vector JEP method does not kill fear, we no longer need to disable merging of OSR guards to enforce Vector API Expansion. Remove setting that option.
Signed-off-by: Rahil Shah rahil@ca.ibm.com