Make unreachableOrphan a member method - #6730
Merged
Merged
Conversation
jamesgua
force-pushed
the
OrphanType
branch
from
September 27, 2022 01:25
39ea3b0 to
be7dc53
Compare
Contributor
Author
|
In our project we need to extend method removeEdge, however method unreachableOrphan is local so I made it a protected member method. And I also found enum Start/EndBlock is declared only but not found anywhere else even in open j9 so I removed it. |
0xdaryl
reviewed
Sep 28, 2022
| int32_t _initialBlockFrequency; | ||
| static const int32_t MAX_PROF_EDGE_FREQ=0x3FFE; | ||
| enum OrphanType | ||
| { |
|
|
||
| TR::Region& getInternalMemoryRegion(); | ||
|
|
||
| //FIXME: These public members should eventually be wrtapped in an interface. |
Contributor
There was a problem hiding this comment.
Please fix spelling of "wrapped" while you're here.
| // test if 'to' is an unreachable orphan | ||
| // | ||
| static OrphanType unreachableOrphan(TR::CFG *cfg, TR::CFGNode *from, TR::CFGNode *to) | ||
| TR::CFG::OrphanType |
Contributor
There was a problem hiding this comment.
This enum isn't extended and lives in the OMR namespace. Shouldn't it be OMR::CFG::OrphanType ?
to be accessible by extended class Signed-off-by: Tao Guan <james_mango@yahoo.com>
jamesgua
force-pushed
the
OrphanType
branch
from
September 29, 2022 02:25
be7dc53 to
2ab9a22
Compare
Contributor
|
Jenkins build all |
0xdaryl
approved these changes
Sep 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to be accessible by extended class
Signed-off-by: Tao Guan james_mango@yahoo.com