Remove vectorToScalar OMRDataType query - #6676
Merged
Merged
Conversation
Contributor
Author
|
@gita-omr Can I please get your review on this? |
Contributor
|
This change will break some of the omr consumers. @r30shah maybe we should try to eliminate the use of that method first? |
Contributor
Author
|
@gita-omr I was checking the use of the method in both omr and openJ9 repo, There is only one consumer atm. Which is in Aliases.cpp. I can not find any other consumer of |
gita-omr
approved these changes
Aug 29, 2022
Contributor
Author
|
Jenkins build all |
1 similar comment
Contributor
Author
|
Jenkins build all |
Remove using vectorToScalar query from codebase and use getVectorElementType() query instead to get the element type of the vector opcode. Closes: eclipse-omr#6658 Signed-off-by: Rahil Shah <rahil@ca.ibm.com>
Contributor
Author
|
Jenkins build all |
Contributor
Author
0xdaryl
approved these changes
Sep 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove using vectorToScalar query from codebase and use
getVectorElementType() query instead to get the element type of the
vector opcode.
Closes: #6658
Signed-off-by: Rahil Shah rahil@ca.ibm.com