Remove dummy opcode value setting in Instruction constructor - #6668
Merged
Conversation
Signed-off-by: Tao Guan <james_mango@yahoo.com>
Contributor
|
jenkins build xlinux,arm |
Contributor
|
Test failure on x86-macOS. I think it is the same as Issue #6556: |
knn-k
approved these changes
Aug 22, 2022
knn-k
left a comment
knn-k
left a comment
Contributor
There was a problem hiding this comment.
LGTM.
I am going to merge this PR tomorrow if there are no other comments, especially for the x86 part.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should be part of #6640 since there were duplicate _opcode member at top level and extended platform level, now no need to enforce such TR::InstOpCode::bad at OMR::Instruction level and set it at platform level.
Signed-off-by: Tao Guan james_mango@yahoo.com