Skip to content

Add Heap Fixup GC Logging and J9MM Tracepoints - #6593

Merged
0xdaryl merged 1 commit into
eclipse-omr:masterfrom
jonoommen:addHeapFixupLoggingAndTracepoints
Sep 28, 2022
Merged

Add Heap Fixup GC Logging and J9MM Tracepoints#6593
0xdaryl merged 1 commit into
eclipse-omr:masterfrom
jonoommen:addHeapFixupLoggingAndTracepoints

Conversation

@jonoommen

@jonoommen jonoommen commented Jun 28, 2022

Copy link
Copy Markdown
Contributor

Add heap fixup verbose GC logging and J9mm tracepoints
for heap fixups that also include the reason for the heap fixup.

Signed-off-by: Jonathan Oommen jon.oommen@gmail.com

@jonoommen
jonoommen force-pushed the addHeapFixupLoggingAndTracepoints branch 2 times, most recently from a12fd0c to 33ff09a Compare June 28, 2022 15:22
@0xdaryl

0xdaryl commented Jun 29, 2022

Copy link
Copy Markdown
Contributor

@amicic @dmitripivkine : would one of you mind reviewing please?

dmitripivkine
dmitripivkine reviewed Jun 30, 2022
View reviewed changes
Comment thread gc/base/standard/CompactScheme.cpp Outdated
amicic
amicic reviewed Jun 30, 2022
View reviewed changes
Comment thread gc/verbose/VerboseHandlerOutput.cpp Outdated
amicic
amicic reviewed Jun 30, 2022
View reviewed changes
Comment thread gc/base/standard/ParallelGlobalGC.cpp Outdated
amicic
amicic reviewed Jun 30, 2022
View reviewed changes
Comment thread gc/base/standard/ParallelGlobalGC.cpp Outdated
@jonoommen
jonoommen force-pushed the addHeapFixupLoggingAndTracepoints branch 3 times, most recently from 818f62a to cd2a95b Compare July 1, 2022 01:01
amicic
amicic reviewed Jul 7, 2022
View reviewed changes
Comment thread gc/base/j9mm.tdf Outdated
amicic
amicic reviewed Jul 7, 2022
View reviewed changes
Comment thread gc/verbose/VerboseHandlerOutput.cpp Outdated
amicic
amicic reviewed Jul 7, 2022
View reviewed changes
Comment thread gc/stats/GlobalGCStats.hpp Outdated
amicic
amicic reviewed Jul 7, 2022
View reviewed changes
Comment thread gc/base/standard/CompactScheme.cpp Outdated
@jonoommen
jonoommen force-pushed the addHeapFixupLoggingAndTracepoints branch 2 times, most recently from 1c5e769 to 1fdc33b Compare July 8, 2022 02:03
amicic
amicic reviewed Jul 11, 2022
View reviewed changes
Comment thread gc/base/j9mm.tdf Outdated
amicic
amicic reviewed Jul 11, 2022
View reviewed changes
Comment thread gc/base/standard/CompactScheme.hpp Outdated
@jonoommen
jonoommen force-pushed the addHeapFixupLoggingAndTracepoints branch 2 times, most recently from fa88dde to ecc7757 Compare July 11, 2022 17:26
amicic
amicic reviewed Jul 11, 2022
View reviewed changes
Comment thread gc/base/standard/CompactScheme.cpp Outdated
@jonoommen
jonoommen force-pushed the addHeapFixupLoggingAndTracepoints branch from ecc7757 to 1467bc4 Compare July 11, 2022 19:46
@dmitripivkine

dmitripivkine commented Jul 12, 2022

Copy link
Copy Markdown
Contributor

Two failures in macOS build look unrelated:

022-07-11T20:22:54.5835230Z 31: /Users/runner/work/1/s/fvtest/porttest/omrsockTest.cpp:1209: Failure
2022-07-11T20:22:54.5868380Z 31:       Expected: rc
2022-07-11T20:22:54.5869720Z 31:       Which is: 1
2022-07-11T20:22:54.5870830Z 31: To be equal to: 2
2022-07-11T20:22:54.5872260Z 31: [  FAILED  ] PortSockTest.poll_functionality_basic (1009 ms)
2022-07-11T20:22:54.5873710Z 31: /Users/runner/work/1/s/fvtest/porttest/omrsockTest.cpp:51: Failure
2022-07-11T20:22:54.5877190Z 31:       Expected: privateOmrPortLibrary->sock_bind(privateOmrPortLibrary, *serverSocket, serverSockAddr)
2022-07-11T20:22:54.5879150Z 31:       Which is: -506
2022-07-11T20:22:54.5880380Z 31: To be equal to: 0
2022-07-11T20:22:54.5881690Z 31: /Users/runner/work/1/s/fvtest/porttest/omrsockTest.cpp:1259: Failure
2022-07-11T20:22:54.5884430Z 31:       Expected: privateOmrPortLibrary->sock_accept(privateOmrPortLibrary, serverSocket, &connectedServerSockAddr, &connectedServerSocket)
2022-07-11T20:22:54.5890150Z 31:       Which is: -20
2022-07-11T20:22:54.5891320Z 31: To be equal to: 0
2022-07-11T20:22:54.5892640Z 31: [  FAILED  ] PortSockTest.poll_functionality_many_sockets (2 ms)
2022-07-11T20:22:54.5894430Z 31: [----------] 19 tests from PortSockTest (1019 ms total)
2022-07-11T20:22:54.5895580Z 31: 
2022-07-11T20:22:54.5896900Z 31: [==========] 244 tests from 21 test cases ran. (155869 ms total)
2022-07-11T20:22:54.5898020Z 31: [  PASSED  ] 242 tests.
2022-07-11T20:22:54.5899160Z 31: [  FAILED  ] 2 tests, listed below:
2022-07-11T20:22:54.5900360Z 31: [  FAILED  ] PortSockTest.poll_functionality_basic
2022-07-11T20:22:54.5902010Z 31: [  FAILED  ] PortSockTest.poll_functionality_many_sockets
2022-07-11T20:22:54.5903230Z 31: 
2022-07-11T20:22:54.5904210Z 31:  2 FAILED TESTS

@0xdaryl

0xdaryl commented Jul 12, 2022

Copy link
Copy Markdown
Contributor

Jenkins build all

@jonoommen
jonoommen force-pushed the addHeapFixupLoggingAndTracepoints branch from 1467bc4 to 3912640 Compare July 12, 2022 19:28
@0xdaryl

0xdaryl commented Jul 12, 2022

Copy link
Copy Markdown
Contributor

Jenkins build all

@jonoommen
Add Heap Fixup GC Logging and J9MM Tracepoints
9d3217d 
Add heap fixup verbose GC logging and J9mm tracepoints
for heap fixups that also include the reason for the heap fixup.

Signed-off-by: Jonathan Oommen jon.oommen@gmail.com
@jonoommen
jonoommen force-pushed the addHeapFixupLoggingAndTracepoints branch from 3912640 to 9d3217d Compare August 24, 2022 17:01
@dmitripivkine

dmitripivkine commented Sep 28, 2022

Copy link
Copy Markdown
Contributor

@babsingh @0xdaryl Are there any concerns about this item? It is waiting for merge for a while

@0xdaryl

0xdaryl commented Sep 28, 2022

Copy link
Copy Markdown
Contributor

Jenkins build all

@0xdaryl

0xdaryl commented Sep 28, 2022

Copy link
Copy Markdown
Contributor

Are there any concerns about this item? It is waiting for merge for a while

Sorry @dmitripivkine @jonoommen. This slipped through the cracks.

@0xdaryl 0xdaryl self-assigned this Sep 28, 2022
@0xdaryl
0xdaryl merged commit 1c5fa23 into eclipse-omr:master Sep 28, 2022
jonoommen added a commit to jonoommen/omr that referenced this pull request Oct 3, 2022
@jonoommen
Fix Heap Fixup Tracing Schema Failure
4d80df5 
Fix heap fixup tracing schema failures due to previously added
heap fixup verbose GC logging and J9mm tracepoints found in
eclipse-omr#6593.

Signed-off-by: Jonathan Oommen jon.oommen@gmail.com
@jonoommen jonoommen mentioned this pull request Oct 3, 2022
Merged
jonoommen added a commit to jonoommen/omr that referenced this pull request Oct 4, 2022
@jonoommen
Fix Heap Fixup Tracing Schema Failure
beed382 
Fix heap fixup tracing schema failures due to previously added
heap fixup verbose GC logging and J9mm tracepoints found in
eclipse-omr#6593.

Signed-off-by: Jonathan Oommen jon.oommen@gmail.com
jonoommen added a commit to jonoommen/omr that referenced this pull request Oct 4, 2022
@jonoommen
Fix Heap Fixup Tracing Schema Failure
3cda28d 
Fix heap fixup tracing schema failures due to previously added
heap fixup verbose GC logging and J9mm tracepoints found in
eclipse-omr#6593.

Signed-off-by: Jonathan Oommen jon.oommen@gmail.com
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xdaryl 0xdaryl 0xdaryl approved these changes
@charliegracie charliegracie Awaiting requested review from charliegracie
@youngar youngar Awaiting requested review from youngar
@rwy7 rwy7 Awaiting requested review from rwy7
+2 more reviewers
@dmitripivkine dmitripivkine dmitripivkine left review comments
@amicic amicic amicic approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@0xdaryl 0xdaryl

Labels

comp:gc

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jonoommen @0xdaryl @dmitripivkine @amicic