Add defaultValueSymbol for value type class - #6530
Merged
Merged
Conversation
Contributor
Author
|
This change is required by eclipse-openj9/openj9#15118 and should be reviewed along with eclipse-openj9/openj9#15118. |
Contributor
|
Jenkins build all |
1 similar comment
Contributor
|
Jenkins build all |
0xdaryl
approved these changes
May 26, 2022
hzongaro
approved these changes
May 26, 2022
hzongaro
left a comment
hzongaro
left a comment
Contributor
There was a problem hiding this comment.
Looks good. I have a really minor comment on the description of the symbol. I'm not sure whether it's worth the bother to change it, or even whether my suggestion is really any better.
This symbol is used to access the default instance associated with a class, if any exists. Signed-off-by: Annabelle Huo <Annabelle.Huo@ibm.com>
a7ehuo
force-pushed
the
defaultvalue-symbol
branch
from
May 26, 2022 17:38
c1a1364 to
6c372db
Compare
Contributor
|
Latest push is a comment change only. Not re-running CI. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
defaultValueSymbolsymbol represents thedefaultValuefield in J9Class.flattenedClassCache.Signed-off-by: Annabelle Huo Annabelle.Huo@ibm.com