Merge from master to 8.0 + fixed nucleus/parent/pom.xml - #25060
Merged
Conversation
- It was referred just from two other constants which had to have the dependency on deployment-common - JWS will be removed soon OR replaced by the Open Web Start Signed-off-by: David MatÄjÄek <david.matejcek@omnifish.ee>
- the sleep can be interrupted - reproduced randomly on local machine - shortened sleep time to 100 ms Signed-off-by: David MatÄjÄek <david.matejcek@omnifish.ee>
Signed-off-by: David MatÄjÄek <david.matejcek@omnifish.ee>
- Added missing logs (when some class was not available, it did not even log it) - Removed e.printstacktrace when we already have logging or throw - Added missing exception cause Signed-off-by: David MatÄjÄek <david.matejcek@omnifish.ee>
- When I broke some classes critical for startup, this was throwing NPE too Signed-off-by: David MatÄjÄek <david.matejcek@omnifish.ee>
Signed-off-by: David MatÄjÄek <david.matejcek@omnifish.ee>
- import order, wildchar imports removed - final fields - redundant modifiers, fixed order - improved braces - improved generics - habitat renamed to locator - using foreach were possible - throwing exceptions with causes Signed-off-by: David MatÄjÄek <david.matejcek@omnifish.ee>
- Now it is injectable - Simplified initialization of related classes Signed-off-by: David MatÄjÄek <david.matejcek@omnifish.ee>
Signed-off-by: David MatÄjÄek <david.matejcek@omnifish.ee>
Signed-off-by: David MatÄjÄek <david.matejcek@omnifish.ee>
Signed-off-by: David MatÄjÄek <david.matejcek@omnifish.ee>
- SSLImplementation is an interface and HK2 Contract, GlassfishSSLImpl
implements it
- SecurityRoleMapperFactoryGen moved to core-ee where is the only usage of it
- SSLConfigurator - lookup removed; in all cases I have seen now works the
locator variant, but I left the class loader variant here for now.
- JSSEImplementation was used just in tests
-> moved there as JSSEImplementation4Tests
- SecureAdminConfigUpgrade - the comment was not true any more
- GlassfishServerSocketFactory now always uses locator
Signed-off-by: David MatÄjÄek <david.matejcek@omnifish.ee>
- Changes based on directly used packages in the module - I will do that with maven plugin later again. Signed-off-by: David MatÄjÄek <david.matejcek@omnifish.ee>
Signed-off-by: David MatÄjÄek <david.matejcek@omnifish.ee>
Refactoring in security (TLS)
- we don't use JSSESupport instances and we don't support Java 1.2 for years. Signed-off-by: David MatÄjÄek <david.matejcek@omnifish.ee>
- Shortened the inheritance to GlassfishServerSocketFactory Signed-off-by: David MatÄjÄek <david.matejcek@omnifish.ee>
- We don't have any other implementation Signed-off-by: David MatÄjÄek <david.matejcek@omnifish.ee>
Signed-off-by: David MatÄjÄek <david.matejcek@omnifish.ee>
- Deleted also javadoc bloc probably copy pasted from some obsoleted JDK Signed-off-by: David MatÄjÄek <david.matejcek@omnifish.ee>
- Also done small improvements in the code ie the attributes map had always just string values. - The DefaultServerSocketFactory is a part of JDK, we don't use it. Signed-off-by: David MatÄjÄek <david.matejcek@omnifish.ee>
Signed-off-by: David MatÄjÄek <david.matejcek@omnifish.ee>
âĶ create() - Now it makes sense, the original impl moved to the SSLConfigurator mostly, and from some point GF required to create just the SSLContext Signed-off-by: David MatÄjÄek <david.matejcek@omnifish.ee>
Signed-off-by: David MatÄjÄek <david.matejcek@omnifish.ee>
Signed-off-by: David MatÄjÄek <david.matejcek@omnifish.ee>
Signed-off-by: David MatÄjÄek <david.matejcek@omnifish.ee>
- Redundant piece in the hierarchy of calls Signed-off-by: David MatÄjÄek <david.matejcek@omnifish.ee>
Signed-off-by: David MatÄjÄek <david.matejcek@omnifish.ee>
Signed-off-by: David MatÄjÄek <david.matejcek@omnifish.ee>
Signed-off-by: David MatÄjÄek <david.matejcek@omnifish.ee>
Signed-off-by: David MatÄjÄek <david.matejcek@omnifish.ee>
Refactoring in grizzly-config: removed dead code
# Conflicts: # appserver/security/core-ee/src/main/java/com/sun/enterprise/security/ee/web/integration/WebSecurityManager.java # nucleus/common/common-util/src/main/java/org/glassfish/security/common/MasterPassword.java # nucleus/security/core/src/main/java/com/sun/enterprise/security/ssl/SSLUtils.java # nucleus/security/ssl-impl/src/main/java/com/sun/enterprise/security/ssl/impl/SecuritySupportImpl.java # nucleus/security/ssl-impl/src/main/java/com/sun/enterprise/server/pluggable/SecuritySupport.java Signed-off-by: David MatÄjÄek <david.matejcek@omnifish.ee>
avpinchuk
approved these changes
Jul 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The nucleus/parent/pom.xml merge was not committed in #25057