Skip to content

Don't use modernize-use-trailing-return-type. - #5169

Merged
trivialfis merged 1 commit into
dmlc:masterfrom
trivialfis:clang-tidy
Dec 29, 2019
Merged

trivialfis merged 1 commit into
dmlc:masterfrom
trivialfis:clang-tidy

Conversation

@trivialfis

Copy link
Copy Markdown
Member

No description provided.

@chyunsu3

Copy link
Copy Markdown
Collaborator

What is the rationale of this change?

@trivialfis

Copy link
Copy Markdown
Member Author

@hcho3 Newer clang-tidy has this option for forcing

auto foo() -> int {
}

style of writing code, I don't think we will do a whole refactor to accommodate it right? As it's more a styling issue instead of solving any real problem.

@trivialfis

Copy link
Copy Markdown
Member Author

It shows up in my editor, kind of distracting.

@trivialfis
trivialfis merged commit d55489a into dmlc:master Dec 29, 2019
@trivialfis
trivialfis deleted the clang-tidy branch December 29, 2019 12:18
@lock lock Bot locked as resolved and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants