Repository navigation
Fix span constructor. - #5166
Merged
Merged
Conversation
* Make sure copy constructor is used.
RAMitchell
reviewed
Jan 7, 2020
RAMitchell
left a comment
Member
There was a problem hiding this comment.
Can you explain a little the situation that makes this necessary?
Member
Author
|
@RAMitchell This is a bug fix, the constructors use compile time dispatching, which choose one constructor when input itself is a Span, and use another constructor for general container like std::vector. Before this PR the constructor for general container is always used. |
RAMitchell
approved these changes
Jan 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.