Skip to content

Fix span constructor. - #5166

Merged
trivialfis merged 1 commit into
dmlc:masterfrom
trivialfis:fix-span-constructor
Jan 7, 2020
Merged

trivialfis merged 1 commit into
dmlc:masterfrom
trivialfis:fix-span-constructor

Conversation

@trivialfis

@trivialfis trivialfis commented Dec 28, 2019 •

Copy link
Copy Markdown
Member
  • Make sure copy constructor is used.
  • Constructor for container no-longer available for device code.

* Make sure copy constructor is used.

@RAMitchell RAMitchell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain a little the situation that makes this necessary?

@trivialfis

Copy link
Copy Markdown
Member Author

@RAMitchell This is a bug fix, the constructors use compile time dispatching, which choose one constructor when input itself is a Span, and use another constructor for general container like std::vector. Before this PR the constructor for general container is always used.

@trivialfis
trivialfis merged commit 77cfbff into dmlc:master Jan 7, 2020
@trivialfis
trivialfis deleted the fix-span-constructor branch January 7, 2020 03:19
@lock lock Bot locked as resolved and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants