Skip to content

Parameter validation - #5157

Merged
trivialfis merged 5 commits into
dmlc:masterfrom
trivialfis:parameter-validate
Dec 26, 2019
Merged

trivialfis merged 5 commits into
dmlc:masterfrom
trivialfis:parameter-validate

Conversation

@trivialfis

@trivialfis trivialfis commented Dec 25, 2019 •

Copy link
Copy Markdown
Member

Related issue: #4211

Using the first option described in: #4211 (comment)

Note the parameter validation is not strict, because we have a lots of parameters packed into TrainParam and each tree method uses only a selected subset. But to me this is a good starting point for future development. The difficult part of getting it work is refactoring approx.

I didn't split the parameters exclusive to CPU Hist, as I think some of them are useful to GPU in the future.

@trivialfis trivialfis changed the title Parameter validate Parameter validation Dec 25, 2019

@RAMitchell RAMitchell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Note the parameter validation is not strict, because we have a lots of parameters packed into TrainParam and each tree method uses only a selected subset.

I'm still open to trying the other approach if you think it's better. You know the relevant code better than I do.

@trivialfis

Copy link
Copy Markdown
Member Author

Nah, one way or the other we will have the same problem. We can refactor the approx after this release.

@trivialfis
trivialfis merged commit f3d7877 into dmlc:master Dec 26, 2019
@trivialfis
trivialfis deleted the parameter-validate branch January 28, 2020 19:16
@lock lock Bot locked as resolved and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants