Repository navigation
Parameter validation - #5157
Merged
Merged
Parameter validation#5157
Conversation
RAMitchell
approved these changes
Dec 25, 2019
RAMitchell
left a comment
Member
There was a problem hiding this comment.
Looks good.
Note the parameter validation is not strict, because we have a lots of parameters packed into TrainParam and each tree method uses only a selected subset.
I'm still open to trying the other approach if you think it's better. You know the relevant code better than I do.
Member
Author
|
Nah, one way or the other we will have the same problem. We can refactor the approx after this release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: #4211
Using the first option described in: #4211 (comment)
Note the parameter validation is not strict, because we have a lots of parameters packed into
TrainParamand each tree method uses only a selected subset. But to me this is a good starting point for future development. The difficult part of getting it work is refactoringapprox.I didn't split the parameters exclusive to CPU Hist, as I think some of them are useful to GPU in the future.