Skip to content

[jvm-packages] Comply with scala style convention - #5134

Merged
chyunsu3 merged 2 commits into
dmlc:masterfrom
chyunsu3:fix_scalastyle
Dec 19, 2019
Merged

chyunsu3 merged 2 commits into
dmlc:masterfrom
chyunsu3:fix_scalastyle

Conversation

@chyunsu3

Copy link
Copy Markdown
Collaborator

Scala style check enforces that all lines be shorter than 100-letters. #4805 introduced a few lines longer than 100-letters and caused the master branch to fail JVM builds.

@sriramch @CodingCat

@chyunsu3
chyunsu3 requested a review from CodingCat December 18, 2019 22:29
@chyunsu3 chyunsu3 changed the title Comply with scala style convention [jvm-packages] Comply with scala style convention Dec 18, 2019
@sriramch

Copy link
Copy Markdown
Contributor

@hcho3 thanks for the super fast turnaround!

@CodingCat

Copy link
Copy Markdown
Member

ah, sorry, I didn't notice this, thanks!

@chyunsu3

Copy link
Copy Markdown
Collaborator Author

@CodingCat Thanks for the quick fix.

@chyunsu3
chyunsu3 merged commit 37fdfa0 into dmlc:master Dec 19, 2019
@chyunsu3
chyunsu3 deleted the fix_scalastyle branch December 19, 2019 01:27
@cpfarrell

Copy link
Copy Markdown
Contributor

Thanks for fixing this and apologies for not catching on making the PR

@lock lock Bot locked as resolved and limited conversation to collaborators Mar 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants