Repository navigation
[jvm-packages] Comply with scala style convention - #5134
Merged
Merged
Conversation
Contributor
|
@hcho3 thanks for the super fast turnaround! |
Member
|
ah, sorry, I didn't notice this, thanks! |
CodingCat
approved these changes
Dec 18, 2019
Collaborator
Author
|
@CodingCat Thanks for the quick fix. |
Contributor
|
Thanks for fixing this and apologies for not catching on making the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scala style check enforces that all lines be shorter than 100-letters. #4805 introduced a few lines longer than 100-letters and caused the master branch to fail JVM builds.
@sriramch @CodingCat