Skip to content

Support gamma in GPU_Hist. - #4874

Merged
trivialfis merged 2 commits into
dmlc:masterfrom
trivialfis:gamma
Sep 24, 2019
Merged

trivialfis merged 2 commits into
dmlc:masterfrom
trivialfis:gamma

Conversation

@trivialfis

Copy link
Copy Markdown
Member

@hcho3 @RAMitchell I just prevent the split when loss_chg < gamma. Could you think of a case adding an explicit pruner is useful? One additional thing I found in pruner is a syncing operation (broadcasting rank 0 tree), but I don't think it's necessary for gpu_hist.

@trivialfis

Copy link
Copy Markdown
Member Author

I will add tests if the method is reasonable.

@RAMitchell

Copy link
Copy Markdown
Member

I can't think of any reason why not, let's do it.

@trivialfis

Copy link
Copy Markdown
Member Author

@RAMitchell Please take a look again.

@trivialfis
trivialfis merged commit 0b89cd1 into dmlc:master Sep 24, 2019
@trivialfis
trivialfis deleted the gamma branch September 24, 2019 02:16
@trivialfis

Copy link
Copy Markdown
Member Author

@panranyang Fixed. #4707

@lock lock Bot locked as resolved and limited conversation to collaborators Dec 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants