Repository navigation
Add check for length of weights. - #4872
Merged
Merged
Conversation
trivialfis
force-pushed
the
check-weight-size
branch
from
October 15, 2019 11:55
b450813 to
468e8d2
Compare
trivialfis
force-pushed
the
check-weight-size
branch
from
December 17, 2019 04:39
468e8d2 to
b88046d
Compare
trivialfis
marked this pull request as ready for review
December 17, 2019 04:44
Member
Author
|
@RAMitchell ping for review. |
RAMitchell
approved these changes
Dec 21, 2019
RAMitchell
left a comment
Member
There was a problem hiding this comment.
Approved as an intermediate solution. Long-term solution is to create proper methods for constructing MetaInfo such that it cannot be constructed in an illegal state. This is preferable to sprinkling checks throughout the rest of xgboost's code. I will try to do this as part of DMatrix refactor.
Member
Author
|
Let's make a constructor for meta info. :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4869 .