Skip to content

Add check for length of weights. - #4872

Merged
trivialfis merged 2 commits into
dmlc:masterfrom
trivialfis:check-weight-size
Dec 21, 2019
Merged

trivialfis merged 2 commits into
dmlc:masterfrom
trivialfis:check-weight-size

Conversation

@trivialfis

@trivialfis trivialfis commented Sep 18, 2019 •

Copy link
Copy Markdown
Member

Closes #4869 .

@trivialfis
trivialfis marked this pull request as ready for review December 17, 2019 04:44
@trivialfis

Copy link
Copy Markdown
Member Author

@RAMitchell ping for review.

@trivialfis
trivialfis requested a review from chyunsu3 December 17, 2019 06:21

@RAMitchell RAMitchell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved as an intermediate solution. Long-term solution is to create proper methods for constructing MetaInfo such that it cannot be constructed in an illegal state. This is preferable to sprinkling checks throughout the rest of xgboost's code. I will try to do this as part of DMatrix refactor.

@trivialfis
trivialfis merged commit c8bdb65 into dmlc:master Dec 21, 2019
@trivialfis
trivialfis deleted the check-weight-size branch December 21, 2019 03:31
@trivialfis

Copy link
Copy Markdown
Member Author

Let's make a constructor for meta info. :-)

@lock lock Bot locked as resolved and limited conversation to collaborators Mar 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sample_weight crashes the interpreter

2 participants