Skip to content

Mimic cuda assert output in span check. - #4762

Merged
trivialfis merged 1 commit into
dmlc:masterfrom
trivialfis:assert
Aug 13, 2019
Merged

trivialfis merged 1 commit into
dmlc:masterfrom
trivialfis:assert

Conversation

@trivialfis

@trivialfis trivialfis commented Aug 12, 2019 •

Copy link
Copy Markdown
Member

KERNEL_CHECK:

Kernel error:
In: /home/fis/Workspace/cuDf/xgboost/tests/cpp/common/test_span.cu: 327
	void xgboost::common::TestAssert2(xgboost::common::Span<unsigned long, -1L>)
	Expecting: _span.size() > 3
	Block: [0, 0, 0], Thread: [0, 0, 0]

Official cuda assert:

/home/fis/Workspace/cuDf/xgboost/tests/cpp/common/test_span.cu:324: void xgboost::common::TestAssert(xgboost::common::Span<unsigned long, -1L>): block: [0,0,0], thread: [0,0,0] Assertion `_span.size() > 3` failed.

@trivialfis
trivialfis requested a review from RAMitchell August 12, 2019 13:36
@trivialfis

Copy link
Copy Markdown
Member Author

@chyunsu3

chyunsu3 commented Aug 12, 2019 •

Copy link
Copy Markdown
Collaborator

@trivialfis I suspect it has to do with concurrency bugs in dmlc-core. See dmlc/dmlc-core#554, dmlc/dmlc-core#550, dmlc/dmlc-core#553. I've been looking at it recently. After I address the bugs, I'd like to enable sanitizer checks in dmlc-core.

@trivialfis
trivialfis merged commit c0ffe65 into dmlc:master Aug 13, 2019
@trivialfis
trivialfis deleted the assert branch August 13, 2019 05:45
@lock lock Bot locked as resolved and limited conversation to collaborators Nov 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants