Skip to content

remove the qids_ field in MetaInfo - #4744

Merged
trivialfis merged 1 commit into
dmlc:masterfrom
rongou:qid
Aug 8, 2019
Merged

trivialfis merged 1 commit into
dmlc:masterfrom
rongou:qid

Conversation

@rongou

@rongou rongou commented Aug 7, 2019

Copy link
Copy Markdown
Contributor

I'm not sure how much we care about saved MetaInfo binaries. If you want I can add the versioning back.

Part of the DMatrix refactoring #4354

@trivialfis @RAMitchell

@trivialfis

Copy link
Copy Markdown
Member

@rongou I'm afraid we have to maintain its stability. Just give a warning for loading old binary.

@codecov-io

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (master@851b5b3). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4744   +/-   ##
=========================================
  Coverage          ?   79.59%           
=========================================
  Files             ?       11           
  Lines             ?     1965           
  Branches          ?        0           
=========================================
  Hits              ?     1564           
  Misses            ?      401           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 851b5b3...3d33218. Read the comment docs.

@rongou

rongou commented Aug 7, 2019

Copy link
Copy Markdown
Contributor Author

@trivialfis added the version. Please take another look.

@trivialfis trivialfis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@trivialfis
trivialfis merged commit 19f9fd5 into dmlc:master Aug 8, 2019
@rongou
rongou deleted the qid branch August 8, 2019 15:56
@lock lock Bot locked as resolved and limited conversation to collaborators Nov 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants