Skip to content

[jvm-packages] Expose setMissing method in trained Model - #4643

Merged
CodingCat merged 1 commit into
dmlc:masterfrom
chyunsu3:set_missing_in_transform
Jul 7, 2019
Merged

CodingCat merged 1 commit into
dmlc:masterfrom
chyunsu3:set_missing_in_transform

Conversation

@chyunsu3

@chyunsu3 chyunsu3 commented Jul 6, 2019

Copy link
Copy Markdown
Collaborator

As discussed in https://discuss.xgboost.ai/t/jvm-packages-v0-90-sparse-vector-prediction-issue-on-missing-values/903/5, we should expose setMissing() method in XGBoostClassificationModel / XGBoostRegressionModel, so that transform() will behave correctly.

@chyunsu3
chyunsu3 requested a review from CodingCat July 6, 2019 21:03
@CodingCat
CodingCat merged commit d333918 into dmlc:master Jul 7, 2019
thesuperzapper pushed a commit to thesuperzapper/xgboost that referenced this pull request Jul 8, 2019
sperlingxx pushed a commit to alipay/ant-xgboost that referenced this pull request Jul 17, 2019
sperlingxx added a commit to alipay/ant-xgboost that referenced this pull request Jul 17, 2019
…ionModel / XGBoostRegressionModel (dmlc#4643)"

This reverts commit 787aeaa.
@lock lock Bot locked as resolved and limited conversation to collaborators Oct 5, 2019
@chyunsu3
chyunsu3 deleted the set_missing_in_transform branch February 20, 2020 03:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants