You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[jvm-packages] expose rabit configuration to user #4861
Good call, env variables initial used to read hadoop default setting. And it was applied to things not necessarily should exists in envs. I would suggest remove at least non hadoop envs and ask caller specifically pass down as arguments so we can log in debug mode.
// initialization function
bool AllreduceBase::Init(int argc, char* argv[]) {
// setup from enviroment variables
// handler to get variables from env
for (size_t i = 0; i < env_vars.size(); ++i) {
const char *value = getenv(env_vars[i].c_str());
if (value != NULL) {
this->SetParam(env_vars[i].c_str(), value);
}
}
// pass in arguments override env variable.
for (int i = 0; i < argc; ++i) {
char name[256], val[256];
if (sscanf(argv[i], "%[^=]=%s", name, val) == 2) {
this->SetParam(name, val);
}
}
Activity
trivialfis commentedon Sep 17, 2019
Firstly I would like to know how many of these are necessarily environment variables? Can they be function parameters? Or use a RPC protocol?
chenqin commentedon Sep 17, 2019
Good call, env variables initial used to read hadoop default setting. And it was applied to things not necessarily should exists in envs. I would suggest remove at least non hadoop envs and ask caller specifically pass down as arguments so we can log in debug mode.
chenqin commentedon Sep 17, 2019
dmlc/rabit#106
chenqin commentedon Sep 19, 2019
#4876