fix(ext/node): validate boolean arg in process.setSourceMapsEnabled - #33473
Merged
bartlomieju merged 2 commits intoApr 25, 2026
Merged
Conversation
Enables tests/node_compat/runner/suite/test/parallel/test-process-setsourcemapsenabled.js
bartlomieju
approved these changes
Apr 25, 2026
bartlomieju
enabled auto-merge (squash)
April 25, 2026 11:45
fibibot
approved these changes
Apr 25, 2026
fibibot
left a comment
fibibot
left a comment
Contributor
There was a problem hiding this comment.
LGTM. validateBoolean (internal/validators.mjs:211) throws ERR_INVALID_ARG_TYPE on the unexpected-value set the upstream parallel/test-process-setsourcemapsenabled.js exercises (undefined, null, 1, {}, () => {}), so the test should land green. Renaming _val â val is required to use it; the comment-side behaviour ("no-op in Deno; source maps always enabled") is preserved. CI is rerunning with 0 failures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enables
test-process-setsourcemapsenabledin node_compat suite.Test plan
cargo test --test node_compat -- test-process-setsourcemapsenabled