Skip to content

Make new qual the default in HaplotypeCaller and GenotypeGVCFs - #5484

Merged
davidbenjamin merged 2 commits into
masterfrom
db_default_qual
Jan 28, 2019
Merged

davidbenjamin merged 2 commits into
masterfrom
db_default_qual

Conversation

@davidbenjamin

Copy link
Copy Markdown
Contributor

@ldgauthier this shouldn't get merged before #5460.

@ldgauthier ldgauthier left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I'd like to wait for this to be the last PR before 4.1 in case anything James (or anyone else) does that affects HaplotypeCaller changes your test outputs. #5318 should go in before this also.


/**
* Use the new allele frequency / QUAL score model
* As of version 4.1.0.0, this argument is no longer needed because the new qual score is now on by default. See GATK 3.3 release notes for more details.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a link to the release notes? Also, would it be helpful to add a link to the model explanation in the repo docs?

@ldgauthier

Copy link
Copy Markdown

@droazen this needs to go in the 4.1 release, but the rebase is potentially going to be a little hairy.

@droazen

droazen commented Jan 25, 2019

Copy link
Copy Markdown
Contributor

@ldgauthier Would it help if I told you that the 4.1 release is much more likely to happen on Tuesday rather than Monday, at this point?

@davidbenjamin

Copy link
Copy Markdown
Contributor Author

The rebase might not be too bad. I've done it before, after all. I will do my best to finish it tonight.

@davidbenjamin

Copy link
Copy Markdown
Contributor Author

HaplotypeCaller, GenotypeGVCFs, and GenomicsDBImport integration tests are all passing locally. I'll check Travis in the morning to see what tests are left to update.

@codecov-io

codecov-io commented Jan 27, 2019 •

Copy link
Copy Markdown

Codecov Report

Merging #5484 into master will decrease coverage by 1.347%.
The diff coverage is 83.333%.

@@               Coverage Diff               @@
##              master     #5484       +/-   ##
===============================================
- Coverage     87.034%   85.687%   -1.347%     
+ Complexity     31535     30938      -597     
===============================================
  Files           1930      1930               
  Lines         145443    145445        +2     
  Branches       16090     16090               
===============================================
- Hits          126585    124627     -1958     
- Misses         12999     14882     +1883     
- Partials        5859      5936       +77
Impacted Files Coverage Δ Complexity Δ
...notyper/GenotypeCalculationArgumentCollection.java 100% <100%> (ø) 2 <0> (ø) ⬇️
...nder/tools/walkers/genotyper/GenotypingEngine.java 69.421% <50%> (-0.413%) 72 <0> (ø)
...ct/CreateSomaticPanelOfNormalsIntegrationTest.java 9.091% <0%> (-90.909%) 2% <0%> (-1%)
...ls/walkers/mutect/CreateSomaticPanelOfNormals.java 0% <0%> (-87.5%) 0% <0%> (-8%)
...r/tools/walkers/mutect/Mutect2IntegrationTest.java 5.061% <0%> (-86.562%) 2% <0%> (-87%)
...alkers/mutect/SomaticReferenceConfidenceModel.java 12.5% <0%> (-84.375%) 1% <0%> (-7%)
...aplotypecaller/HaplotypeCallerIntegrationTest.java 5.643% <0%> (-82.619%) 9% <0%> (-75%)
...ls/genomicsdb/GenomicsDBImportIntegrationTest.java 9.313% <0%> (-79.157%) 2% <0%> (-80%)
...kers/haplotypecaller/ReferenceConfidenceUtils.java 0% <0%> (-66.667%) 0% <0%> (-1%)
...der/tools/HaplotypeCallerSparkIntegrationTest.java 2.439% <0%> (-65.854%) 2% <0%> (-14%)
... and 66 more

@davidbenjamin

Copy link
Copy Markdown
Contributor Author

This one's a bit thornier than it was before but I just fixed locally the sole discrepancy that Travis reported. This push might do it. . .

@davidbenjamin

Copy link
Copy Markdown
Contributor Author

@ldgauthier Ready for you to look at.

@droazen

droazen commented Jan 28, 2019

Copy link
Copy Markdown
Contributor

No additional changes that might affect the HaplotypeCaller output are slated to be merged before the 4.1 release tomorrow, so today would be a good time to get this one in @ldgauthier @davidbenjamin

@ldgauthier ldgauthier left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @davidbenjamin ! I'm excited to finally get this in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants