Repository navigation
Make new qual the default in HaplotypeCaller and GenotypeGVCFs - #5484
Conversation
1eb7df2 to
47248f0
Compare
ldgauthier
left a comment
There was a problem hiding this comment.
Looks good, but I'd like to wait for this to be the last PR before 4.1 in case anything James (or anyone else) does that affects HaplotypeCaller changes your test outputs. #5318 should go in before this also.
|
|
||
| /** | ||
| * Use the new allele frequency / QUAL score model | ||
| * As of version 4.1.0.0, this argument is no longer needed because the new qual score is now on by default. See GATK 3.3 release notes for more details. |
There was a problem hiding this comment.
Can you add a link to the release notes? Also, would it be helpful to add a link to the model explanation in the repo docs?
|
@droazen this needs to go in the 4.1 release, but the rebase is potentially going to be a little hairy. |
|
@ldgauthier Would it help if I told you that the 4.1 release is much more likely to happen on Tuesday rather than Monday, at this point? |
|
The rebase might not be too bad. I've done it before, after all. I will do my best to finish it tonight. |
47248f0 to
0354f0f
Compare
|
HaplotypeCaller, GenotypeGVCFs, and GenomicsDBImport integration tests are all passing locally. I'll check Travis in the morning to see what tests are left to update. |
Codecov Report
@@ Coverage Diff @@
## master #5484 +/- ##
===============================================
- Coverage 87.034% 85.687% -1.347%
+ Complexity 31535 30938 -597
===============================================
Files 1930 1930
Lines 145443 145445 +2
Branches 16090 16090
===============================================
- Hits 126585 124627 -1958
- Misses 12999 14882 +1883
- Partials 5859 5936 +77
|
13e7da8 to
9a98f2d
Compare
|
This one's a bit thornier than it was before but I just fixed locally the sole discrepancy that Travis reported. This push might do it. . . |
8f5c44f to
d824f35
Compare
d824f35 to
76e58da
Compare
|
@ldgauthier Ready for you to look at. |
|
No additional changes that might affect the |
ldgauthier
left a comment
There was a problem hiding this comment.
Looks good @davidbenjamin ! I'm excited to finally get this in.
@ldgauthier this shouldn't get merged before #5460.