Repository navigation
Fix intermittent OSX CI errors - #842
Merged
Merged
Conversation
We were seeing intermittent failures in OSX CI. This seems to be because the symbol address lookup was returning invalid addresses on OSX . We check to make sure the interpreter address is valid after getting the address from symbols, and if it isn't we fallback to scanning the BSS section for the interpreter. On OSX, this fallback wasn't always getting triggered - if the _PyRuntime address pointed to valid memory we would detect that the it was invalid and trigger the fallback - but if it pointed to an invalid address in the target process we just returned an error and failed to load. This caused intermittent failures on CI. This fix makes it so that we will run the BSS ballback even if the _PyRuntime address points to invalid memory. Fixing the OSX symbol resolution so that we get valid addresses will happen in a separate PR.
Owner
Author
|
symbol fix is #843 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were seeing intermittent failures in OSX CI. This seems to be because the symbol address lookup was returning invalid addresses on OSX .
We check to make sure the interpreter address is valid after getting the address from symbols, and if it isn't we fallback to scanning the BSS section for the interpreter. On OSX, this fallback wasn't always getting triggered - if the _PyRuntime address pointed to valid memory we would detect that the it was invalid and trigger the fallback - but if it pointed to an invalid address in the target process we just returned an error and failed to load. This caused intermittent failures on CI. This fix makes it so that we will run the BSS fallback even if the _PyRuntime address points to invalid memory.
Fixing the OSX symbol resolution so that we get valid addresses will happen in a separate PR (and is also blocking changes like #835)