Skip to content

Fix intermittent OSX CI errors - #842

Merged
benfred merged 1 commit into
masterfrom
fix_bss_fallback
Apr 23, 2026
Merged

benfred merged 1 commit into
masterfrom
fix_bss_fallback

Conversation

@benfred

@benfred benfred commented Apr 23, 2026 •

Copy link
Copy Markdown
Owner

We were seeing intermittent failures in OSX CI. This seems to be because the symbol address lookup was returning invalid addresses on OSX .

We check to make sure the interpreter address is valid after getting the address from symbols, and if it isn't we fallback to scanning the BSS section for the interpreter. On OSX, this fallback wasn't always getting triggered - if the _PyRuntime address pointed to valid memory we would detect that the it was invalid and trigger the fallback - but if it pointed to an invalid address in the target process we just returned an error and failed to load. This caused intermittent failures on CI. This fix makes it so that we will run the BSS fallback even if the _PyRuntime address points to invalid memory.

Fixing the OSX symbol resolution so that we get valid addresses will happen in a separate PR (and is also blocking changes like #835)

We were seeing intermittent failures in OSX CI. This seems to be because
the symbol address lookup was returning invalid addresses on OSX .

We check to make sure the interpreter address is valid after getting the
address from symbols, and if it isn't we fallback to scanning the BSS section
for the interpreter.  On OSX, this fallback wasn't always getting triggered -
if the _PyRuntime address pointed to valid memory we would detect that
the it was invalid and trigger the fallback - but if it pointed to an
invalid address in the target process we just returned an error and failed
to load. This caused intermittent failures on CI. This fix makes it
so that we will run the BSS ballback even if the _PyRuntime address
points to invalid memory.

Fixing the OSX symbol resolution so that we get valid addresses will
happen in a separate PR.
@benfred benfred added the bug Something isn't working label Apr 23, 2026
@benfred
benfred merged commit f84084a into master Apr 23, 2026
108 checks passed
@benfred

benfred commented Apr 23, 2026

Copy link
Copy Markdown
Owner Author

symbol fix is #843

@benfred
benfred deleted the fix_bss_fallback branch April 24, 2026 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant