Skip to content
This repository was archived by the owner on Jun 22, 2026. It is now read-only.

fix: enable package --diff for jobs and prevent output of full template - #5685

Merged
mergify[bot] merged 1 commit into
aws:mainlinefrom
CaptainCarpensir:cli/fix-package-diff-commands
Feb 23, 2024
Merged

mergify[bot] merged 1 commit into
aws:mainlinefrom
CaptainCarpensir:cli/fix-package-diff-commands

Conversation

@CaptainCarpensir

@CaptainCarpensir CaptainCarpensir commented Feb 22, 2024 •

Copy link
Copy Markdown
Contributor

Fixes two things:

  1. job package --diff is actually enabled, the flag wasn't passed into the command before
  2. don't output the template in the event that there are no changes in package --diff

Addresses #5684

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.

@CaptainCarpensir
CaptainCarpensir requested a review from a team as a code owner February 22, 2024 23:24
@CaptainCarpensir
CaptainCarpensir requested review from Lou1415926 and removed request for a team February 22, 2024 23:24
@codecov-commenter

codecov-commenter commented Feb 22, 2024 •

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 70.04%. Comparing base (e1f500c) to head (9b07adf).

Files Patch % Lines
internal/pkg/cli/job_package.go 0.00% 2 Missing ⚠️
internal/pkg/cli/env_package.go 0.00% 1 Missing ⚠️
internal/pkg/cli/svc_package.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           mainline    #5685      +/-   ##
============================================
- Coverage     70.05%   70.04%   -0.01%     
============================================
  Files           303      303              
  Lines         46626    46630       +4     
  Branches        299      299              
============================================
  Hits          32663    32663              
- Misses        12379    12383       +4     
  Partials       1584     1584              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions

github-actions Bot commented Feb 22, 2024 •

Copy link
Copy Markdown

🍕 Here are the new binary sizes!

Name New size (kiB) size (kiB) Delta (%)
macOS (amd) 57588 57312 +0.48
macOS (arm) 58620 58332 +0.49
linux (amd) 50492 50256 +0.47
linux (arm) 49728 49540 +0.38
windows (amd) 47564 47344 +0.46

@CaptainCarpensir CaptainCarpensir changed the title fix: package --diff fixes fix: enable package --diff for jobs and prevent output of full template Feb 22, 2024
@mergify
mergify Bot merged commit 50bd4e4 into aws:mainline Feb 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants