Skip to content
This repository was archived by the owner on Jun 22, 2026. It is now read-only.

fix: svc package for rdws when image.build is used - #5638

Merged
mergify[bot] merged 3 commits into
aws:mainlinefrom
KollaAdithya:rdws/svc/package/fix
Jan 26, 2024
Merged

mergify[bot] merged 3 commits into
aws:mainlinefrom
KollaAdithya:rdws/svc/package/fix

Conversation

@KollaAdithya

Copy link
Copy Markdown
Contributor

related #5634

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.

@KollaAdithya
KollaAdithya requested a review from a team as a code owner January 26, 2024 19:25
@KollaAdithya
KollaAdithya requested review from efekarakus and removed request for a team January 26, 2024 19:25
@github-actions

github-actions Bot commented Jan 26, 2024 •

Copy link
Copy Markdown

🍕 Here are the new binary sizes!

Name New size (kiB) size (kiB) Delta (%)
macOS (amd) 57216 57132 +0.15
macOS (arm) 58232 58156 +0.13
linux (amd) 50172 50096 +0.15
linux (arm) 49472 49348 +0.25
windows (amd) 47268 47200 +0.14

@iamhopaul123 iamhopaul123 added the do-not-merge Pull requests that mergify shouldn't merge until the requester allows it. label Jan 26, 2024
Co-authored-by: Penghao He <penghaoh@amazon.com>
@codecov-commenter

codecov-commenter commented Jan 26, 2024 •

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 70.05%. Comparing base (a72c893) to head (011ea20).
Report is 109 commits behind head on mainline.

Files with missing lines Patch % Lines
...ternal/pkg/deploy/cloudformation/stack/workload.go 50.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           mainline    #5638      +/-   ##
============================================
+ Coverage     70.03%   70.05%   +0.01%     
============================================
  Files           303      303              
  Lines         46623    46625       +2     
  Branches        299      299              
============================================
+ Hits          32654    32661       +7     
+ Misses        12384    12378       -6     
- Partials       1585     1586       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@KollaAdithya KollaAdithya removed the do-not-merge Pull requests that mergify shouldn't merge until the requester allows it. label Jan 26, 2024
@mergify
mergify Bot merged commit 7e4350b into aws:mainline Jan 26, 2024
@KollaAdithya
KollaAdithya deleted the rdws/svc/package/fix branch January 26, 2024 21:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants