Skip to content
This repository was archived by the owner on Jun 22, 2026. It is now read-only.

fix: respect image.location uri for containers - #5555

Merged
mergify[bot] merged 3 commits into
aws:mainlinefrom
Lou1415926:fix/container/image/build
Dec 12, 2023
Merged

mergify[bot] merged 3 commits into
aws:mainlinefrom
Lou1415926:fix/container/image/build

Conversation

@Lou1415926

@Lou1415926 Lou1415926 commented Dec 12, 2023 •

Copy link
Copy Markdown
Contributor

Addresses: #5501 (comment)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.

@Lou1415926
Lou1415926 requested a review from a team as a code owner December 12, 2023 21:41
@Lou1415926
Lou1415926 requested review from efekarakus and removed request for a team December 12, 2023 21:41
@Lou1415926 Lou1415926 added the WIP Pull requests that are being modified now. label Dec 12, 2023
@Lou1415926
Lou1415926 force-pushed the fix/container/image/build branch from 3cdbee2 to f1e340e Compare December 12, 2023 21:43
@codecov-commenter

codecov-commenter commented Dec 12, 2023 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.05%. Comparing base (98bacee) to head (8c19fc3).
⚠️ Report is 154 commits behind head on mainline.

Additional details and impacted files
@@             Coverage Diff              @@
##           mainline    #5555      +/-   ##
============================================
- Coverage     70.05%   70.05%   -0.01%     
============================================
  Files           302      302              
  Lines         46335    46338       +3     
  Branches        301      301              
============================================
+ Hits          32459    32460       +1     
- Misses        12302    12305       +3     
+ Partials       1574     1573       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Dec 12, 2023 •

Copy link
Copy Markdown

🍕 Here are the new binary sizes!

Name New size (kiB) size (kiB) Delta (%)
macOS (amd) 56800 55192 🥺 +2.91
macOS (arm) 57796 56144 🥺 +2.94
linux (amd) 49808 48440 🥺 +2.82
linux (arm) 49088 47748 🥺 +2.81
windows (amd) 46928 45672 🥺 +2.75

@CaptainCarpensir CaptainCarpensir left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, waiting for tests to be finished to approve 👍

Comment on lines -98 to +101
imageURI := rc.PushedImages[name].URI()
var imageURI string
if image, ok := rc.PushedImages[name]; ok {
imageURI = image.URI()
}

@CaptainCarpensir CaptainCarpensir Dec 12, 2023 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not feedback but I found this snippet of code to be really interesting in Go!

The new code is definitely a more idiomatic way to approach the problem because it doesn't use what feels like a side effect of the language, but they actually have the exact same output. I was curious so I wrote this in the Go Playground to test.

❤️ Great catch on this since it's not actually part of the bug.

@Lou1415926
Lou1415926 force-pushed the fix/container/image/build branch from f1e340e to 5c366ff Compare December 12, 2023 23:05
@Lou1415926 Lou1415926 removed the WIP Pull requests that are being modified now. label Dec 12, 2023

@CaptainCarpensir CaptainCarpensir left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - e2e tests please pass 🙏

@mergify
mergify Bot merged commit dd7f30c into aws:mainline Dec 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants