Skip to content
This repository was archived by the owner on Jun 22, 2026. It is now read-only.

fix: add quotes to fix the invalid template for svc package for static site - #5498

Merged
mergify[bot] merged 2 commits into
aws:mainlinefrom
KollaAdithya:ogbuild/len
Nov 22, 2023
Merged

mergify[bot] merged 2 commits into
aws:mainlinefrom
KollaAdithya:ogbuild/len

Conversation

@KollaAdithya

Copy link
Copy Markdown
Contributor

Related: #5472 (comment)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.

@KollaAdithya
KollaAdithya requested a review from a team as a code owner November 21, 2023 04:25
@KollaAdithya
KollaAdithya requested review from huanjani and removed request for a team November 21, 2023 04:25
@codecov-commenter

codecov-commenter commented Nov 21, 2023 •

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (382fe1a) 70.03% compared to head (fcc7167) 70.03%.

Additional details and impacted files
@@            Coverage Diff            @@
##           mainline    #5498   +/-   ##
=========================================
  Coverage     70.03%   70.03%           
=========================================
  Files           302      302           
  Lines         46064    46064           
  Branches        309      309           
=========================================
  Hits          32261    32261           
  Misses        12237    12237           
  Partials       1566     1566           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions

github-actions Bot commented Nov 21, 2023 •

Copy link
Copy Markdown

🍕 Here are the new binary sizes!

Name New size (kiB) size (kiB) Delta (%)
macOS (amd) 56268 55192 🥺 +1.95
macOS (arm) 57272 56144 🥺 +2.01
linux (amd) 49340 48440 🥺 +1.86
linux (arm) 48640 47748 🥺 +1.87
windows (amd) 46504 45672 🥺 +1.82

@mergify
mergify Bot merged commit 262eefa into aws:mainline Nov 22, 2023
@iamhopaul123 iamhopaul123 changed the title chore: add quotes to fix the invalid template for svc package for static site fix: add quotes to fix the invalid template for svc package for static site Dec 11, 2023
@KollaAdithya
KollaAdithya deleted the ogbuild/len branch December 20, 2023 22:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants