Skip to content

Show more nonprinting characters in diagnostic fix diffs - #30062

Merged
MichaReiser merged 1 commit into
mainfrom
micha/show-nonprinting-diff-characters
Nov 5, 2026
Merged

MichaReiser merged 1 commit into
mainfrom
micha/show-nonprinting-diff-characters

Conversation

@MichaReiser

@MichaReiser MichaReiser commented Nov 5, 2026 •

Copy link
Copy Markdown
Member

Summary

After #30017, ruff format --check shows a deletion for a file containing only a byte order mark (BOM), but the deleted line looks empty. Render the BOM as � so the deletion is visible.

Fix diffs also show ASCII controls such as NUL as ␀, display bidirectional formatting controls as �, and omit zero-width joiners. This aligns our behavior with annotated snippets, with the exception of tabs (I left that unchanged for now). We could use the helper provided by annotated snippets if we decide to also replace tab characters with four spaces.

Test Plan

Updated the formatter and linter snapshots and ran the CLI, diagnostic renderer, and linter tests.

@MichaReiser MichaReiser added the diagnostics Diagnostic messages, annotations, fixes & rendering infra--not for PRs that just add new diagnostics label Nov 5, 2026
@astral-automations-bot

Copy link
Copy Markdown
Contributor

Memory usage report

Memory usage unchanged ✅


Results for 81a33cf · Workflow run

@MichaReiser MichaReiser changed the title Show nonprinting characters in diagnostic fix diffs Show more nonprinting characters in diagnostic fix diffs Nov 5, 2026
@astral-automations-bot

Copy link
Copy Markdown
Contributor

ecosystem-analyzer results

No diagnostic changes detected ✅

Full report with detailed diff · Timing results


Results for 81a33cf · Workflow run

@astral-automations-bot

Copy link
Copy Markdown
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Linter (stable) · Linter (preview)


Results for 81a33cf · Workflow run

@MichaReiser
MichaReiser marked this pull request as ready for review November 5, 2026 10:28
@MichaReiser
MichaReiser requested a review from a team as a code owner November 5, 2026 10:28
@MichaReiser
MichaReiser merged commit 1dd3e9e into main Nov 5, 2026
78 checks passed
@MichaReiser
MichaReiser deleted the micha/show-nonprinting-diff-characters branch November 5, 2026 17:03
rlichtenwalter added a commit to rlichtenwalter/dir2text that referenced this pull request Nov 13, 2026
This PR contains the following updates:

| Package | Type | Update | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) |
|---|---|---|---|---|---|
| [DavidAnson/markdownlint-cli2](https://github.com/DavidAnson/markdownlint-cli2) | repository | patch | `v0.24.0` → `v0.24.1` | ![age](https://developer.mend.io/api/mc/badges/age/github-tags/DavidAnson%2fmarkdownlint-cli2/v0.24.1?slim=true) | ![confidence](https://developer.mend.io/api/mc/badges/confidence/github-tags/DavidAnson%2fmarkdownlint-cli2/v0.24.0/v0.24.1?slim=true) |
| [rbubley/mirrors-prettier](https://github.com/rbubley/mirrors-prettier) | repository | minor | `v3.9.10` → `v3.10.1` | ![age](https://developer.mend.io/api/mc/badges/age/github-tags/rbubley%2fmirrors-prettier/v3.10.1?slim=true) | ![confidence](https://developer.mend.io/api/mc/badges/confidence/github-tags/rbubley%2fmirrors-prettier/v3.9.10/v3.10.1?slim=true) |
| [ruff](https://docs.astral.sh/ruff) ([source](https://github.com/astral-sh/ruff), [changelog](https://github.com/astral-sh/ruff/blob/main/CHANGELOG.md)) | dependency-groups | patch | `==0.17.3` → `==0.17.5` | ![age](https://developer.mend.io/api/mc/badges/age/pypi/ruff/0.17.5?slim=true) | ![confidence](https://developer.mend.io/api/mc/badges/confidence/pypi/ruff/0.17.3/0.17.5?slim=true) |

Note: The `pre-commit` manager in Renovate is not supported by the `pre-commit` maintainers or community. Please do not report any problems there, instead [create a Discussion in the Renovate repository](https://github.com/renovatebot/renovate/discussions/new) if you have any questions.

---

### Release Notes

<details>
<summary>DavidAnson/markdownlint-cli2</summary>

### [`v0.24.1`](DavidAnson/markdownlint-cli2@v0.24.0...v0.24.1)

[Compare Source](DavidAnson/markdownlint-cli2@v0.24.0...v0.24.1)

</details>

<details>
<summary>rbubley/mirrors-prettier</summary>

### [`v3.10.1`](rbubley/mirrors-prettier@v3.10.0...v3.10.1)

[Compare Source](rbubley/mirrors-prettier@v3.10.0...v3.10.1)

### [`v3.10.0`](rbubley/mirrors-prettier@v3.9.10...v3.10.0)

[Compare Source](rbubley/mirrors-prettier@v3.9.10...v3.10.0)

</details>

<details>
<summary>astral-sh/ruff (ruff)</summary>

### [`v0.17.5`](https://github.com/astral-sh/ruff/blob/HEAD/CHANGELOG.md#0175)

[Compare Source](astral-sh/ruff@0.17.4...0.17.5)

Released on 2026-11-12.

##### Preview features

- Redirect renamed rules ([#&#8203;30081](astral-sh/ruff#30081))
- \[`flake8-async`] Implement `pytest-raises-exception-group` (`ASYNC401`) ([#&#8203;28772](astral-sh/ruff#28772))
- \[`flake8-logging-format`] Mark `G004` fix as unsafe ([#&#8203;30087](astral-sh/ruff#30087))
- \[`pylint`] Implement `no-method-argument` (`PLE0211`) ([#&#8203;29748](astral-sh/ruff#29748))
- \[`refurb`] Do not offer fix when `write` is nested in an expression (`FURB103`) ([#&#8203;29789](astral-sh/ruff#29789))
- \[`ruff`] Add `renamed-rule` (`RUF202`) ([#&#8203;30079](astral-sh/ruff#30079))
- \[`ruff`] Expand `redirected-noqa` to other suppression comments (`RUF101`) ([#&#8203;30078](astral-sh/ruff#30078))

##### Bug fixes

- Avoid crashing when Ruff logs to a closed stderr pipe ([#&#8203;30209](astral-sh/ruff#30209))
- Fix fixes that add or remove a keyword argument with a parenthesized value ([#&#8203;30189](astral-sh/ruff#30189))
- \[`flake8-import-conventions`] Avoid shadowing names when fixing import aliases (`ICN001`) ([#&#8203;30035](astral-sh/ruff#30035))
- \[`flake8-bugbear`] Fix `B010` autofix for parenthesized `setattr` calls ([#&#8203;30168](astral-sh/ruff#30168))
- \[`flake8-pyi`] Fix `PYI034` autofix for parenthesized `self` annotations ([#&#8203;30173](astral-sh/ruff#30173))
- \[`pyupgrade`] Fix `UP031` duplicating closing parentheses around the format string ([#&#8203;30172](astral-sh/ruff#30172))

##### Rule changes

- \[`flake8-bugbear`] Ignore frozen dataclass instantiations (`B008`) ([#&#8203;29231](astral-sh/ruff#29231))

##### Performance

- Various performance improvements ([#&#8203;30375](astral-sh/ruff#30375), [#&#8203;30211](astral-sh/ruff#30211), [#&#8203;30368](astral-sh/ruff#30368), [#&#8203;30259](astral-sh/ruff#30259), [#&#8203;30354](astral-sh/ruff#30354), [#&#8203;30115](astral-sh/ruff#30115), [#&#8203;30133](astral-sh/ruff#30133), [#&#8203;30132](astral-sh/ruff#30132), [#&#8203;30358](astral-sh/ruff#30358), [#&#8203;30135](astral-sh/ruff#30135), [#&#8203;30369](astral-sh/ruff#30369), [#&#8203;30351](astral-sh/ruff#30351), [#&#8203;30352](astral-sh/ruff#30352), [#&#8203;30347](astral-sh/ruff#30347), [#&#8203;30379](astral-sh/ruff#30379), [#&#8203;30328](astral-sh/ruff#30328), [#&#8203;30329](astral-sh/ruff#30329), [#&#8203;29446](astral-sh/ruff#29446))

##### Other changes

- Fix FreeBSD source builds with libc 0.2.190 ([#&#8203;30176](astral-sh/ruff#30176))

##### Contributors

- [@&#8203;rajveer3x](https://github.com/rajveer3x)
- [@&#8203;tjkuson](https://github.com/tjkuson)
- [@&#8203;hugehoo](https://github.com/hugehoo)
- [@&#8203;hector2394](https://github.com/hector2394)
- [@&#8203;ansh-rohilla](https://github.com/ansh-rohilla)
- [@&#8203;mati-caliz](https://github.com/mati-caliz)
- [@&#8203;yxshee](https://github.com/yxshee)
- [@&#8203;charliermarsh](https://github.com/charliermarsh)
- [@&#8203;MichaReiser](https://github.com/MichaReiser)
- [@&#8203;GeorgiaPreda](https://github.com/GeorgiaPreda)
- [@&#8203;G26karthik](https://github.com/G26karthik)
- [@&#8203;ntBre](https://github.com/ntBre)
- [@&#8203;s-cork](https://github.com/s-cork)

### [`v0.17.4`](https://github.com/astral-sh/ruff/blob/HEAD/CHANGELOG.md#0174)

[Compare Source](astral-sh/ruff@0.17.3...0.17.4)

Released on 2026-11-05.

##### Preview features

- \[`flake8-logging-format`] Avoid behavior changes and syntax errors in fixes (`G004`) ([#&#8203;27419](astral-sh/ruff#27419))
- \[`security`] Implement `tarfile-ignore-zeros-true` ([#&#8203;28680](astral-sh/ruff#28680))

##### Bug fixes

- Accept a bare raise before a semicolon ([#&#8203;29761](astral-sh/ruff#29761))
- Allow match identifiers after a semicolon ([#&#8203;29760](astral-sh/ruff#29760))
- Fix panic on BOM-prefixed files in diagnostic renderer ([#&#8203;30017](astral-sh/ruff#30017))
- \[`flake8-simplify`] Report collapsible `elif` clauses after a multi-statement `if` branch (`SIM102`) ([#&#8203;29814](astral-sh/ruff#29814))

##### Rule changes

- Show more nonprinting characters in diagnostic fix diffs ([#&#8203;30062](astral-sh/ruff#30062))

##### Performance

- Coalesce source slices when formatting attributes ([#&#8203;29841](astral-sh/ruff#29841))
- Collect return statements with a statement-only visitor ([#&#8203;29911](astral-sh/ruff#29911))

(PR body shortened for the merge commit; full text on the PR.)

Reviewed-on: https://git.lichtenwalter.site/rlichten/dir2text/pulls/109

This branch was previously deployed

1 inactive deployment
automations — 81a33cfc Deployed Nov 5, 2026 by MichaReiser via security-review / security review #97312
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

diagnostics Diagnostic messages, annotations, fixes & rendering infra--not for PRs that just add new diagnostics

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants