Repository navigation
[MNG-6979] Initialize the current project from the execution root (backport of #13103 to 4.0.x) - #13143
Merged
Conversation
âĶache#13103) Use the selected execution root as the initial current project, retaining the first selected project as fallback when the root is absent. This keeps lifecycle participants independent of reactor dependency ordering. Add regression coverage for lifecycle project selection, empty and filtered reactors, thread-local state, and cloned sessions.
gnodet-bot
approved these changes
Sep 15, 2026
gnodet-bot
left a comment
Contributor
There was a problem hiding this comment.
Clean backport of #13103 to maven-4.0.x. The reorder in setProjects() is correct: computing topLevelProject first (execution root, or projects.get(0) as fallback) and then using it as the ThreadLocal initial value ensures currentProject and topLevelProject are always in sync, regardless of reactor ordering.
Test coverage is solid: unit tests cover the root-at-any-position case, the fallback-to-first case, ThreadLocal isolation across threads, clone independence, and the setProjects reset semantics. The integration-level testCurrentProjectSelection confirms the full participant lifecycle works end-to-end. Nothing missing.
This review was generated by an AI agent, HermÃĻs on behalf of @gnodet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #13103 to the
maven-4.0.xbranch.Cherry-pick of 4c3a661, applied cleanly with no conflicts.