Skip to content

Add a MeasureType to Quake - #869

Merged
schweitzpgi merged 4 commits into
NVIDIA:mainfrom
schweitzpgi:ch-measure.type
Nov 15, 2023
Merged

schweitzpgi merged 4 commits into
NVIDIA:mainfrom
schweitzpgi:ch-measure.type

Conversation

@schweitzpgi

Copy link
Copy Markdown
Collaborator

Adds a new type for the result of a measurement operation. A value of type !quake.measurement must be post-processed by the new operation quake.discriminate to convert that value to a classical integer value. quake.discriminate, like the previous measurement ops, can produce either a single integer (bit) or a std::vector of integers (bits).

This splits the measurement operation into two steps:

  • acquiring the measurement on a qubit(s)
  • converting the measurement results to a classical value(s).

Fix all the tests and passes to accept the new representation.

@github-actions

github-actions Bot commented Nov 6, 2023

Copy link
Copy Markdown

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions Bot pushed a commit that referenced this pull request Nov 6, 2023
@schweitzpgi schweitzpgi linked an issue Nov 6, 2023 that may be closed by this pull request
@schweitzpgi schweitzpgi added the enhancement New feature or request label Nov 6, 2023
@github-actions

github-actions Bot commented Nov 6, 2023

Copy link
Copy Markdown

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions Bot pushed a commit that referenced this pull request Nov 6, 2023
@github-actions

github-actions Bot commented Nov 7, 2023

Copy link
Copy Markdown

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

@github-actions

github-actions Bot commented Nov 8, 2023

Copy link
Copy Markdown

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions Bot pushed a commit that referenced this pull request Nov 8, 2023
@github-actions

github-actions Bot commented Nov 8, 2023

Copy link
Copy Markdown

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions Bot pushed a commit that referenced this pull request Nov 8, 2023
@github-actions

github-actions Bot commented Nov 8, 2023

Copy link
Copy Markdown

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions Bot pushed a commit that referenced this pull request Nov 8, 2023
@github-actions

Copy link
Copy Markdown

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions Bot pushed a commit that referenced this pull request Nov 13, 2023
@NVIDIA NVIDIA deleted a comment from copy-pr-bot Bot Nov 14, 2023
Adds a new type for the result of a measurement operation. A value of
type `!quake.measurement` must be post-processed by the new operation
`quake.discriminate` to convert that value to a classical integer value.
`quake.discriminate`, like the previous measurement ops, can produce
either a single integer (bit) or a `std::vector` of integers (bits).

This splits the measurement operation into two steps:
  - acquiring the measurement on a qubit(s)
  - converting the measurement results to a classical value(s).

Fix all the tests and passes to accept the new representation.

Add verifier for DiscriminateOp.

Update the python tests.
@github-actions

Copy link
Copy Markdown

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions Bot pushed a commit that referenced this pull request Nov 14, 2023

@bmhowe23 bmhowe23 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just one overarching question about the pattern matching (mostly for my own benefit).

Comment thread lib/Frontend/nvqpp/ConvertDecl.cpp Resolved
@github-actions

Copy link
Copy Markdown

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions Bot pushed a commit that referenced this pull request Nov 14, 2023

@1tnguyen 1tnguyen left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@github-actions

Copy link
Copy Markdown

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions Bot pushed a commit that referenced this pull request Nov 15, 2023
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 15, 2023
@bettinaheim bettinaheim changed the title Add a MeasureType to Quake. Add a MeasureType to Quake Jan 22, 2024
@bettinaheim bettinaheim added this to the release 0.6.0 milestone Jan 22, 2024
@bettinaheim bettinaheim added release notes Changes need to be captured in the release notes and removed enhancement New feature or request labels Jan 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release notes Changes need to be captured in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add dedicated type for measurement results in Quake

4 participants