Repository navigation
Make ordering of matrix class configurable - #3126
Merged
Merged
Conversation
Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>
Collaborator
Author
Command Bot: Processing... |
@amccaskey, there was an error processing your request: See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/1/ |
Collaborator
Author
Command Bot: Processing... |
Collaborator
Author
Command Bot: Processing... |
@amccaskey, there was an error processing your request: See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/1/ |
Collaborator
Author
Command Bot: Processing... |
schweitzpgi
enabled auto-merge (squash)
June 30, 2025 23:21
Collaborator
Author
Command Bot: Processing... |
Collaborator
Command Bot: Processing... |
Collaborator
Author
Command Bot: Processing... |
nvidia-dobri
approved these changes
Jul 1, 2025
Collaborator
Author
Command Bot: Processing... |
bettinaheim
reviewed
Jul 1, 2025
Signed-off-by: Bettina Heim <heimb@outlook.com>
Signed-off-by: Bettina Heim <heimb@outlook.com>
Signed-off-by: Bettina Heim <heimb@outlook.com>
Signed-off-by: Bettina Heim <heimb@outlook.com>
Signed-off-by: Bettina Heim <heimb@outlook.com>
Signed-off-by: Bettina Heim <heimb@outlook.com>
Add enum parameter to get_data
bettinaheim
approved these changes
Jul 18, 2025
Signed-off-by: Bettina Heim <heimb@outlook.com>
…cuda-quantum into remove_pybind_runtime
Collaborator
Command Bot: Processing... |
bettinaheim
disabled auto-merge
July 22, 2025 10:54
atgeller
pushed a commit
to atgeller/cuda-quantum
that referenced
this pull request
Jul 31, 2025
Signed-off-by: Alex McCaskey <amccaskey@nvidia.com> Signed-off-by: Bettina Heim <heimb@outlook.com> Co-authored-by: Eric Schweitz <eschweitz@nvidia.com> Co-authored-by: Bettina Heim <heimb@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looking through some other PRs, I saw pybind code in
cudaq/utils/matrix.h(note it was just forward declared there) and Python functions were marked asfriend. The reason for this was to allow Python runtime code to have access to the raw data pointer for thecomplex_matrix.This removes those declarations and the pybind forward declaration, and exposes a
get_data(complex_matrix::order)method oncomplex_matrix. To avoid relying on internal ordering convention, the function requires an explicit argument to define whether the data is expected to be column major or row major. If the requested order does not match the current data format, the internal representation will be reordered as needed. Correspondingly, to avoid unnecessary reordering, the order can now also be provided upon construction of the matrix.