Repository navigation
New pass to expand veqs into individual arguments when used as controls - #1829
Merged
Merged
Conversation
|
CLA Assistant Lite bot All Contributors have signed the CLA. |
schweitzpgi
reviewed
Jun 17, 2024
schweitzpgi
left a comment
Collaborator
There was a problem hiding this comment.
Nice work, Adam. Let's see if we can't deploy this using rewrite patterns.
schweitzpgi
reviewed
Jun 18, 2024
schweitzpgi
left a comment
Collaborator
There was a problem hiding this comment.
Looks great and quick work. Thanks for doing this, Adam.
A few minor nits.
Collaborator
|
Looks like it'll need a clang-format run on the .cpp file. |
Co-authored-by: Eric Schweitz <eschweitz@nvidia.com>
schweitzpgi
reviewed
Jun 28, 2024
schweitzpgi
reviewed
Jun 28, 2024
schweitzpgi
left a comment
Collaborator
There was a problem hiding this comment.
This looks good. We should move ahead with merging it.
atgeller
marked this pull request as ready for review
July 2, 2024 23:16
Collaborator
Command Bot: Processing... |
schweitzpgi
approved these changes
Jul 2, 2024
schweitzpgi
enabled auto-merge (squash)
July 2, 2024 23:18
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
auto-merge was automatically disabled
July 3, 2024 18:43
Head branch was pushed to by a user without write access
Collaborator
Command Bot: Processing... |
1tnguyen
enabled auto-merge (squash)
July 4, 2024 02:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a pass
expand-control-veqsto expand veqs used as controls into individual control qubits.For example, given an operation of the form
quake.any [%veq] %r : (!quake.veq<n>, !quake.ref) -> (), this pass will extract each qubit from%veq%and explicitly provide them as qubits: