Skip to content

Correctly handle 'break' within nested loops in Python - #1693

Merged
khalatepradnya merged 1 commit into
NVIDIA:mainfrom
khalatepradnya:fix/issue-1682
May 17, 2024
Merged

khalatepradnya merged 1 commit into
NVIDIA:mainfrom
khalatepradnya:fix/issue-1682

Conversation

@khalatepradnya

Copy link
Copy Markdown
Collaborator

@khalatepradnya khalatepradnya self-assigned this May 17, 2024
@khalatepradnya khalatepradnya linked an issue May 17, 2024 that may be closed by this pull request
4 tasks done
@khalatepradnya khalatepradnya added the bug fix To be listed under Bug Fixes in the release notes label May 17, 2024
* The 'break' statement visitor in Python AST bridge did not account for
  multiple nested loops
* Also fixed the same issue for 'continue' statement
* Added the example from GitHub issue as a test
@github-actions

Copy link
Copy Markdown

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions Bot pushed a commit that referenced this pull request May 17, 2024

@bmhowe23 bmhowe23 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@github-actions

Copy link
Copy Markdown

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions Bot pushed a commit that referenced this pull request May 17, 2024
@khalatepradnya
khalatepradnya merged commit 44f3da3 into NVIDIA:main May 17, 2024
@khalatepradnya
khalatepradnya deleted the fix/issue-1682 branch May 17, 2024 22:03
@github-actions github-actions Bot locked and limited conversation to collaborators May 17, 2024
@khalatepradnya khalatepradnya added python-lang Anything related to the Python CUDA Quantum language implementation python bridge Involves the python bridge to quake labels Jul 19, 2024
@bettinaheim bettinaheim changed the title [Bug-fix] [Python] Correctly handle 'break' within nested loops Correctly handle 'break' within nested loops in Python Jul 29, 2024
@bettinaheim bettinaheim added this to the release 0.8.0 milestone Jul 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug fix To be listed under Bug Fixes in the release notes python bridge Involves the python bridge to quake python-lang Anything related to the Python CUDA Quantum language implementation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

break within two loops is not handled right.

3 participants