Skip to content

Use arch-specific pip requirements and update docs - #1602

Merged
bmhowe23 merged 22 commits into
NVIDIA:mainfrom
bmhowe23:pr-test-x86-pip-reqs
May 10, 2024
Merged

bmhowe23 merged 22 commits into
NVIDIA:mainfrom
bmhowe23:pr-test-x86-pip-reqs

Conversation

@bmhowe23

@bmhowe23 bmhowe23 commented May 2, 2024 •

Copy link
Copy Markdown
Collaborator

Resolves #1570.
Resolves #1601.

With these changes, x86 installation doesn't require any conda packages for most use cases, so it installs on Linux with a simple, standalone, pip install cuda-quantum now; however, aarch64 and multi-gpu x86 configurations still requires conda packages to be installed and LD_LIBRARY_PATH to be set.

Run demonstrating a failure:
https://github.com/NVIDIA/cuda-quantum/actions/runs/9035103824/job/24829689361

Run demonstrating success:
https://github.com/NVIDIA/cuda-quantum/actions/runs/9035426262/job/24830644405

@github-actions

github-actions Bot commented May 2, 2024

Copy link
Copy Markdown

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions Bot pushed a commit that referenced this pull request May 2, 2024
@github-actions

github-actions Bot commented May 3, 2024

Copy link
Copy Markdown

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions Bot pushed a commit that referenced this pull request May 3, 2024
bmhowe23 added 4 commits May 3, 2024 21:11
This won't necessarily allow ldd to work, but if all the right packages
are installed, then you should be able to set_target().
@github-actions

github-actions Bot commented May 3, 2024

Copy link
Copy Markdown

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions Bot pushed a commit that referenced this pull request May 3, 2024
@github-actions

github-actions Bot commented May 6, 2024

Copy link
Copy Markdown

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions Bot pushed a commit that referenced this pull request May 6, 2024
@bmhowe23 bmhowe23 added documentation Improvements or additions to documentation user experience Issue or PR that significantly impacts user experience labels May 6, 2024
@bmhowe23 bmhowe23 changed the title [DRAFT] Try arch-specific pip requirements [DRAFT] Use arch-specific pip requirements and update docs May 6, 2024
@github-actions

github-actions Bot commented May 6, 2024

Copy link
Copy Markdown

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions Bot pushed a commit that referenced this pull request May 6, 2024
@bmhowe23 bmhowe23 changed the title [DRAFT] Use arch-specific pip requirements and update docs Use arch-specific pip requirements and update docs May 7, 2024
@github-actions

github-actions Bot commented May 7, 2024

Copy link
Copy Markdown

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions Bot pushed a commit that referenced this pull request May 7, 2024
@bmhowe23

bmhowe23 commented May 8, 2024

Copy link
Copy Markdown
Collaborator Author

(My own documentation...)
The first publishing attempt on this PR had an issue, but it might have been due to how I ran the Deployment/Publishing for this PR, so I will update the branch and try again.

@github-actions

github-actions Bot commented May 8, 2024

Copy link
Copy Markdown

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions Bot pushed a commit that referenced this pull request May 8, 2024
@bmhowe23

bmhowe23 commented May 9, 2024

Copy link
Copy Markdown
Collaborator Author

Successful run of new publishing test is here: https://github.com/NVIDIA/cuda-quantum/actions/runs/9021070758/job/24788111764

@github-actions

github-actions Bot commented May 9, 2024

Copy link
Copy Markdown

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions Bot pushed a commit that referenced this pull request May 9, 2024
github-actions Bot pushed a commit that referenced this pull request May 10, 2024
@github-actions

Copy link
Copy Markdown

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

@bettinaheim bettinaheim added this to the release 0.8.0 milestone May 10, 2024
Comment thread .github/workflows/publishing.yml Resolved
Comment thread pyproject.toml Resolved
@github-actions

Copy link
Copy Markdown

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions Bot pushed a commit that referenced this pull request May 10, 2024

@bettinaheim bettinaheim left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Much nicer at least for x86...

@github-actions

Copy link
Copy Markdown

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions Bot pushed a commit that referenced this pull request May 10, 2024
@bmhowe23 bmhowe23 closed this May 10, 2024
@github-actions github-actions Bot locked and limited conversation to collaborators May 10, 2024

This branch was previously deployed

1 inactive deployment
ghcr-deployment — 2e378790 Deployed May 10, 2024 by bmhowe23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

documentation Improvements or additions to documentation user experience Issue or PR that significantly impacts user experience

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing rpath links and dependencies for cuda-quantum PyPi package [documentation] Clearly document supported operating systems for pip wheels

2 participants