Repository navigation
[tools] Fix segfault in cudaq-translate when emit-llvm=0 - #1557
Merged
Merged
Conversation
This patch fixes a segmentation fault in `cudaq-translate` when "--emit-llvm" is false. The issue occurs because the initialization lambda has non-trivial storage, and `llvm::function_ref` only holds a reference to a function, trashing the lambda after initialization.
|
CLA Assistant Lite bot All Contributors have signed the CLA. |
Contributor
Author
|
I have read the Contributor License Agreement and I hereby accept the Terms. |
Contributor
Author
|
recheck |
cuda-quantum-bot
added a commit
that referenced
this pull request
Apr 23, 2024
Collaborator
Command Bot: Processing... |
schweitzpgi
reviewed
Apr 23, 2024
schweitzpgi
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the bug fix, Fabian.
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
schweitzpgi
approved these changes
Apr 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch fixes a segmentation fault in
cudaq-translatewhen--emit-llvmis false. The issue occurs because the initialization lambda has non-trivial storage, andllvm::function_refonly holds a reference to a function, trashing the lambda after initialization.