Repository navigation
Chemistry related bug fixes - #1099
Conversation
Command Bot: Processing... |
Command Bot: Processing... |
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
bmhowe23
left a comment
There was a problem hiding this comment.
Do our chemistry interfaces need to remain stable? I.e., should the old function interfaces (generateExcitations, singletExcitation, doubletExcitation, uccsd_num_parameters, and uccsd) be retained and/or deprecated? We normally try to do that for other interfaces, but I'm not sure about this one.
No. These will ultimately be moved to library code that builds atop cuda-quantum outside of this repository. With this PR I'm simply fixing a bug so that users of the current code can still use it while the libraries are being implemented. |
1tnguyen
left a comment
There was a problem hiding this comment.
Looking good. Fixing a tricky bug in UCCSD 👍
Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>
Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>
Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>
Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>
Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>
Command Bot: Processing... |
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
Command Bot: Processing... |
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
UCCSD bug fixes, implementation adapted from @marwafar
Fixes #952