Skip to content

Chemistry related bug fixes - #1099

Merged
amccaskey merged 6 commits into
NVIDIA:mainfrom
amccaskey:uccsdFix
Jan 20, 2024
Merged

amccaskey merged 6 commits into
NVIDIA:mainfrom
amccaskey:uccsdFix

Conversation

@amccaskey

@amccaskey amccaskey commented Jan 17, 2024 •

Copy link
Copy Markdown
Collaborator

UCCSD bug fixes, implementation adapted from @marwafar

Fixes #952

@copy-pr-bot

copy-pr-bot Bot commented Jan 17, 2024

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@amccaskey

amccaskey commented Jan 17, 2024 •

Copy link
Copy Markdown
Collaborator Author

/ok to test

Command Bot: Processing...

@amccaskey

amccaskey commented Jan 17, 2024 •

Copy link
Copy Markdown
Collaborator Author

/ok to test

Command Bot: Processing...

@github-actions

Copy link
Copy Markdown

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions Bot pushed a commit that referenced this pull request Jan 18, 2024

@bmhowe23 bmhowe23 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do our chemistry interfaces need to remain stable? I.e., should the old function interfaces (generateExcitations, singletExcitation, doubletExcitation, uccsd_num_parameters, and uccsd) be retained and/or deprecated? We normally try to do that for other interfaces, but I'm not sure about this one.

@amccaskey

Copy link
Copy Markdown
Collaborator Author

Do our chemistry interfaces need to remain stable? I.e., should the old function interfaces (generateExcitations, singletExcitation, doubletExcitation, uccsd_num_parameters, and uccsd) be retained and/or deprecated? We normally try to do that for other interfaces, but I'm not sure about this one.

No. These will ultimately be moved to library code that builds atop cuda-quantum outside of this repository. With this PR I'm simply fixing a bug so that users of the current code can still use it while the libraries are being implemented.

@1tnguyen 1tnguyen left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Fixing a tricky bug in UCCSD 👍

Comment thread unittests/domains/ChemistryTester.cpp Resolved
Comment thread runtime/cudaq/domains/chemistry/uccsd.h Resolved
Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>
Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>
Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>
Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>
Signed-off-by: Alex McCaskey <amccaskey@nvidia.com>
@amccaskey

amccaskey commented Jan 19, 2024 •

Copy link
Copy Markdown
Collaborator Author

/ok to test

Command Bot: Processing...

@amccaskey
amccaskey enabled auto-merge (squash) January 19, 2024 18:16
@github-actions

Copy link
Copy Markdown

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions Bot pushed a commit that referenced this pull request Jan 19, 2024
@amccaskey

amccaskey commented Jan 20, 2024 •

Copy link
Copy Markdown
Collaborator Author

/ok to test

Command Bot: Processing...

@amccaskey
amccaskey requested a review from bmhowe23 January 20, 2024 13:04
@github-actions

Copy link
Copy Markdown

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions Bot pushed a commit that referenced this pull request Jan 20, 2024

@bmhowe23 bmhowe23 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@amccaskey
amccaskey merged commit add7101 into NVIDIA:main Jan 20, 2024
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 20, 2024
@bmhowe23 bmhowe23 added the bug fix To be listed under Bug Fixes in the release notes label Jan 20, 2024
@bettinaheim bettinaheim added this to the release 0.6.0 milestone Jan 22, 2024
@bettinaheim bettinaheim changed the title UCCSD Bug Fixes #952 Chemistry related bug fixes Jan 23, 2024
@amccaskey
amccaskey deleted the uccsdFix branch February 29, 2024 20:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug fix To be listed under Bug Fixes in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UCCSD code in the latest version (0.4.1) is incorrect

6 participants