Skip to content

Fix density matrix qubit ordering bug - #1033

Merged
anthony-santana merged 16 commits into
NVIDIA:mainfrom
anthony-santana:dm_bug
Dec 18, 2023
Merged

anthony-santana merged 16 commits into
NVIDIA:mainfrom
anthony-santana:dm_bug

Conversation

@anthony-santana

@anthony-santana anthony-santana commented Dec 12, 2023 •

Copy link
Copy Markdown
Collaborator

Description

Fixes a bug on the QPP density matrix backend where the qubit ordering was getting flipped after adding additional qubits mid-circuit.

@copy-pr-bot

copy-pr-bot Bot commented Dec 12, 2023

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Comment thread unittests/backends/QPPTester.cpp Resolved
Comment thread unittests/backends/QPPTester.cpp Resolved
@anthony-santana anthony-santana changed the title [DON'T MERGE] density matrix simulator bit ordering Fix density matrix qubit ordering bug Dec 13, 2023
@anthony-santana
anthony-santana marked this pull request as ready for review December 13, 2023 18:58
@anthony-santana
anthony-santana enabled auto-merge (squash) December 13, 2023 18:59
@anthony-santana

anthony-santana commented Dec 13, 2023 •

Copy link
Copy Markdown
Collaborator Author

/ok to test

Command Bot: Processing...

@bmhowe23 bmhowe23 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@bmhowe23 bmhowe23 added the bug fix To be listed under Bug Fixes in the release notes label Dec 13, 2023

@schweitzpgi schweitzpgi left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fixes.

Comment thread unittests/backends/QPPTester.cpp Resolved
@anthony-santana

anthony-santana commented Dec 13, 2023 •

Copy link
Copy Markdown
Collaborator Author

/ok to test

Command Bot: Processing...

@anthony-santana

anthony-santana commented Dec 13, 2023 •

Copy link
Copy Markdown
Collaborator Author

/ok to test

Command Bot: Processing...

@github-actions

Copy link
Copy Markdown

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions Bot pushed a commit that referenced this pull request Dec 13, 2023

@1tnguyen 1tnguyen left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great👍

Signed-off-by: A.M. Santana <anthonys@nvidia.com>
…ion test is failing but as a false flag

Signed-off-by: A.M. Santana <anthonys@nvidia.com>
Signed-off-by: A.M. Santana <anthonys@nvidia.com>
Signed-off-by: A.M. Santana <anthonys@nvidia.com>
Signed-off-by: A.M. Santana <anthonys@nvidia.com>
Signed-off-by: A.M. Santana <anthonys@nvidia.com>
Signed-off-by: A.M. Santana <anthonys@nvidia.com>
Signed-off-by: A.M. Santana <anthonys@nvidia.com>
Signed-off-by: A.M. Santana <anthonys@nvidia.com>
Signed-off-by: A.M. Santana <anthonys@nvidia.com>
Signed-off-by: A.M. Santana <anthonys@nvidia.com>
Signed-off-by: A.M. Santana <anthonys@nvidia.com>
Signed-off-by: A.M. Santana <anthonys@nvidia.com>
Signed-off-by: A.M. Santana <anthonys@nvidia.com>
Signed-off-by: A.M. Santana <anthonys@nvidia.com>
Signed-off-by: A.M. Santana <anthonys@nvidia.com>
@anthony-santana

anthony-santana commented Dec 18, 2023 •

Copy link
Copy Markdown
Collaborator Author

/ok to test

Command Bot: Processing...

@anthony-santana
anthony-santana merged commit 1f9b964 into NVIDIA:main Dec 18, 2023
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 18, 2023
@bettinaheim bettinaheim added this to the release 0.6.0 milestone Jan 22, 2024
@anthony-santana
anthony-santana deleted the dm_bug branch March 18, 2024 15:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug fix To be listed under Bug Fixes in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants