Skip to content

make value_types_of_t and error_types_of_t work with non-variadic templates - #5134

Merged
ericniebler merged 1 commit into
NVIDIA:mainfrom
ericniebler:meta-apply-completion-traits
Jul 3, 2025
Merged

ericniebler merged 1 commit into
NVIDIA:mainfrom
ericniebler:meta-apply-completion-traits

Conversation

@ericniebler

Copy link
Copy Markdown
Contributor

Description

in the standard here, the alias templates execution::value_types_of_t and execution::error_types_of_t are defined in terms of an exposition-only pseudo-macro META-APPLY. the standard even tells you why:

image

in the cudax implementation, those alias templates are not doing the proper META-APPLY dance. this pr brings [value|error]_types_of_t into compliance.

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@copy-pr-bot

copy-pr-bot Bot commented Jul 3, 2025

Copy link
Copy Markdown
Contributor

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@cccl-authenticator-app cccl-authenticator-app Bot moved this from Todo to In Progress in CCCL Jul 3, 2025
@ericniebler

Copy link
Copy Markdown
Contributor Author

/ok to test db25cca

@ericniebler
ericniebler marked this pull request as ready for review July 3, 2025 00:19
@ericniebler
ericniebler requested a review from a team as a code owner July 3, 2025 00:19
@ericniebler
ericniebler requested a review from pciolkosz July 3, 2025 00:19
@cccl-authenticator-app cccl-authenticator-app Bot moved this from In Progress to In Review in CCCL Jul 3, 2025
@github-actions

github-actions Bot commented Jul 3, 2025

Copy link
Copy Markdown
Contributor
🟩 CI finished in 18m 58s: Pass: 100%/32 | Total: 3h 54m | Avg: 7m 20s | Max: 15m 17s | Hits: 85%/16218
  • 🟩 cudax: Pass: 100%/28 | Total: 3h 40m | Avg: 7m 52s | Max: 15m 17s | Hits: 85%/16218

    🟩 cpu
      🟩 amd64              Pass: 100%/24  | Total:  3h 17m | Avg:  8m 13s | Max: 15m 17s | Hits:  85%/13730 
      🟩 arm64              Pass: 100%/4   | Total: 23m 13s | Avg:  5m 48s | Max:  6m 21s | Hits:  85%/2488  
    🟩 ctk
      🟩 12.0               Pass: 100%/3   | Total: 24m 57s | Avg:  8m 19s | Max: 14m 13s | Hits:  82%/1565  
      🟩 12.9               Pass: 100%/25  | Total:  3h 15m | Avg:  7m 49s | Max: 15m 17s | Hits:  86%/14653 
    🟩 cudacxx
      🟩 nvcc12.0           Pass: 100%/3   | Total: 24m 57s | Avg:  8m 19s | Max: 14m 13s | Hits:  82%/1565  
      🟩 nvcc12.9           Pass: 100%/25  | Total:  3h 15m | Avg:  7m 49s | Max: 15m 17s | Hits:  86%/14653 
    🟩 cudacxx_family
      🟩 nvcc               Pass: 100%/28  | Total:  3h 40m | Avg:  7m 52s | Max: 15m 17s | Hits:  85%/16218 
    🟩 cxx
      🟩 Clang14            Pass: 100%/2   | Total: 10m 45s | Avg:  5m 22s | Max:  5m 51s | Hits:  86%/1246  
      🟩 Clang15            Pass: 100%/1   | Total:  5m 49s | Avg:  5m 49s | Max:  5m 49s | Hits:  85%/622   
      🟩 Clang16            Pass: 100%/1   | Total:  5m 54s | Avg:  5m 54s | Max:  5m 54s | Hits:  85%/622   
      🟩 Clang17            Pass: 100%/1   | Total:  5m 43s | Avg:  5m 43s | Max:  5m 43s | Hits:  85%/622   
      🟩 Clang18            Pass: 100%/1   | Total:  6m 16s | Avg:  6m 16s | Max:  6m 16s | Hits:  85%/622   
      🟩 Clang19            Pass: 100%/4   | Total: 25m 33s | Avg:  6m 23s | Max:  8m 38s | Hits:  89%/2488  
      🟩 GCC10              Pass: 100%/2   | Total: 12m 42s | Avg:  6m 21s | Max:  6m 52s | Hits:  85%/1246  
      🟩 GCC11              Pass: 100%/1   | Total:  6m 17s | Avg:  6m 17s | Max:  6m 17s | Hits:  85%/622   
      🟩 GCC12              Pass: 100%/1   | Total:  7m 04s | Avg:  7m 04s | Max:  7m 04s | Hits:  85%/622   
      🟩 GCC13              Pass: 100%/8   | Total: 57m 08s | Avg:  7m 08s | Max: 11m 29s | Hits:  89%/4976  
      🟩 MSVC14.39          Pass: 100%/1   | Total: 14m 13s | Avg: 14m 13s | Max: 14m 13s | Hits:  68%/321   
      🟩 MSVC14.43          Pass: 100%/3   | Total: 42m 45s | Avg: 14m 15s | Max: 15m 17s | Hits:  68%/969   
      🟩 NVHPC25.5          Pass: 100%/2   | Total: 20m 26s | Avg: 10m 13s | Max: 10m 42s | Hits:  83%/1240  
    🟩 cxx_family
      🟩 Clang              Pass: 100%/10  | Total:  1h 00m | Avg:  6m 00s | Max:  8m 38s | Hits:  87%/6222  
      🟩 GCC                Pass: 100%/12  | Total:  1h 23m | Avg:  6m 55s | Max: 11m 29s | Hits:  87%/7466  
      🟩 MSVC               Pass: 100%/4   | Total: 56m 58s | Avg: 14m 14s | Max: 15m 17s | Hits:  68%/1290  
      🟩 NVHPC              Pass: 100%/2   | Total: 20m 26s | Avg: 10m 13s | Max: 10m 42s | Hits:  83%/1240  
    🟩 gpu
      🟩 h100               Pass: 100%/2   | Total: 14m 33s | Avg:  7m 16s | Max:  9m 43s | Hits:  92%/1244  
      🟩 rtx2080            Pass: 100%/26  | Total:  3h 26m | Avg:  7m 55s | Max: 15m 17s | Hits:  85%/14974 
    🟩 jobs
      🟩 Build              Pass: 100%/25  | Total:  3h 10m | Avg:  7m 37s | Max: 15m 17s | Hits:  83%/14352 
      🟩 Test               Pass: 100%/3   | Total: 29m 50s | Avg:  9m 56s | Max: 11m 29s | Hits:  99%/1866  
    🟩 sm
      🟩 90                 Pass: 100%/2   | Total: 14m 33s | Avg:  7m 16s | Max:  9m 43s | Hits:  92%/1244  
      🟩 90;90a             Pass: 100%/2   | Total: 19m 39s | Avg:  9m 49s | Max: 13m 43s | Hits:  79%/945   
      🟩 100;120            Pass: 100%/2   | Total: 20m 04s | Avg: 10m 02s | Max: 13m 45s | Hits:  79%/945   
    🟩 std
      🟩 17                 Pass: 100%/3   | Total: 20m 44s | Avg:  6m 54s | Max:  9m 44s | Hits:  84%/1864  
      🟩 20                 Pass: 100%/25  | Total:  3h 19m | Avg:  7m 59s | Max: 15m 17s | Hits:  85%/14354 
    
  • 🟩 packaging: Pass: 100%/4 | Total: 14m 12s | Avg: 3m 33s | Max: 3m 57s

    🟩 cpu
      🟩 amd64              Pass: 100%/4   | Total: 14m 12s | Avg:  3m 33s | Max:  3m 57s
    🟩 ctk
      🟩 12.0               Pass: 100%/2   | Total:  7m 16s | Avg:  3m 38s | Max:  3m 57s
      🟩 12.9               Pass: 100%/2   | Total:  6m 56s | Avg:  3m 28s | Max:  3m 42s
    🟩 cudacxx
      🟩 nvcc12.0           Pass: 100%/2   | Total:  7m 16s | Avg:  3m 38s | Max:  3m 57s
      🟩 nvcc12.9           Pass: 100%/2   | Total:  6m 56s | Avg:  3m 28s | Max:  3m 42s
    🟩 cudacxx_family
      🟩 nvcc               Pass: 100%/4   | Total: 14m 12s | Avg:  3m 33s | Max:  3m 57s
    🟩 cxx
      🟩 Clang14            Pass: 100%/1   | Total:  3m 19s | Avg:  3m 19s | Max:  3m 19s
      🟩 Clang19            Pass: 100%/1   | Total:  3m 42s | Avg:  3m 42s | Max:  3m 42s
      🟩 GCC12              Pass: 100%/1   | Total:  3m 57s | Avg:  3m 57s | Max:  3m 57s
      🟩 GCC13              Pass: 100%/1   | Total:  3m 14s | Avg:  3m 14s | Max:  3m 14s
    🟩 cxx_family
      🟩 Clang              Pass: 100%/2   | Total:  7m 01s | Avg:  3m 30s | Max:  3m 42s
      🟩 GCC                Pass: 100%/2   | Total:  7m 11s | Avg:  3m 35s | Max:  3m 57s
    🟩 gpu
      🟩 rtx2080            Pass: 100%/4   | Total: 14m 12s | Avg:  3m 33s | Max:  3m 57s
    🟩 jobs
      🟩 Test               Pass: 100%/4   | Total: 14m 12s | Avg:  3m 33s | Max:  3m 57s
    

👃 Inspect Changes

Modifications in project?

Project
CCCL Infrastructure
CCCL Packaging
libcu++
CUB
Thrust
+/- CUDA Experimental
stdpar
python
CCCL C Parallel Library
Catch2Helper

Modifications in project or dependencies?

Project
CCCL Infrastructure
+/- CCCL Packaging
libcu++
CUB
Thrust
+/- CUDA Experimental
stdpar
python
CCCL C Parallel Library
Catch2Helper

🏃‍ Runner counts (total jobs: 32)

# Runner
17 linux-amd64-cpu16
6 linux-amd64-gpu-rtx2080-latest-1
4 windows-amd64-cpu16
4 linux-arm64-cpu16
1 linux-amd64-gpu-h100-latest-1

@ericniebler
ericniebler merged commit eafe76a into NVIDIA:main Jul 3, 2025
@github-project-automation github-project-automation Bot moved this from In Review to Done in CCCL Jul 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants