Repository navigation
refactor opstates and receivers to shorten mangled names - #5065
Merged
Merged
Conversation
Contributor
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
Author
|
/ok to test 8bfabd0 |
Contributor
Author
|
/ok to test 90354ed |
Contributor
🟨 CI finished in 40m 57s: Pass: 81%/32 | Total: 3h 58m | Avg: 7m 27s | Max: 26m 14s | Hits: 93%/13528
|
| Project | |
|---|---|
| CCCL Infrastructure | |
| CCCL Packaging | |
| libcu++ | |
| CUB | |
| Thrust | |
| +/- | CUDA Experimental |
| stdpar | |
| python | |
| CCCL C Parallel Library | |
| Catch2Helper |
Modifications in project or dependencies?
| Project | |
|---|---|
| CCCL Infrastructure | |
| +/- | CCCL Packaging |
| libcu++ | |
| CUB | |
| Thrust | |
| +/- | CUDA Experimental |
| stdpar | |
| python | |
| CCCL C Parallel Library | |
| Catch2Helper |
🏃 Runner counts (total jobs: 32)
| # | Runner |
|---|---|
| 17 | linux-amd64-cpu16 |
| 6 | linux-amd64-gpu-rtx2080-latest-1 |
| 4 | windows-amd64-cpu16 |
| 4 | linux-arm64-cpu16 |
| 1 | linux-amd64-gpu-h100-latest-1 |
Contributor
|
/ok to test fabac5a |
miscco
reviewed
Jun 26, 2025
miscco
reviewed
Jun 26, 2025
miscco
left a comment
Contributor
There was a problem hiding this comment.
I find it quite confusing that we are now having types that are names like variables, this makes all of this even harder to read
Contributor
🟨 CI finished in 17m 10s: Pass: 87%/32 | Total: 3h 12m | Avg: 6m 01s | Max: 12m 57s | Hits: 95%/14760
|
| Project | |
|---|---|
| CCCL Infrastructure | |
| CCCL Packaging | |
| libcu++ | |
| CUB | |
| Thrust | |
| +/- | CUDA Experimental |
| stdpar | |
| python | |
| CCCL C Parallel Library | |
| Catch2Helper |
Modifications in project or dependencies?
| Project | |
|---|---|
| CCCL Infrastructure | |
| +/- | CCCL Packaging |
| libcu++ | |
| CUB | |
| Thrust | |
| +/- | CUDA Experimental |
| stdpar | |
| python | |
| CCCL C Parallel Library | |
| Catch2Helper |
🏃 Runner counts (total jobs: 32)
| # | Runner |
|---|---|
| 17 | linux-amd64-cpu16 |
| 6 | linux-amd64-gpu-rtx2080-latest-1 |
| 4 | windows-amd64-cpu16 |
| 4 | linux-arm64-cpu16 |
| 1 | linux-amd64-gpu-h100-latest-1 |
Contributor
Author
|
/ok to test 07bc332 |
Contributor
🟨 CI finished in 19m 06s: Pass: 96%/32 | Total: 3h 17m | Avg: 6m 09s | Max: 12m 47s | Hits: 94%/15708
|
| Project | |
|---|---|
| CCCL Infrastructure | |
| CCCL Packaging | |
| libcu++ | |
| CUB | |
| Thrust | |
| +/- | CUDA Experimental |
| stdpar | |
| python | |
| CCCL C Parallel Library | |
| Catch2Helper |
Modifications in project or dependencies?
| Project | |
|---|---|
| CCCL Infrastructure | |
| +/- | CCCL Packaging |
| libcu++ | |
| CUB | |
| Thrust | |
| +/- | CUDA Experimental |
| stdpar | |
| python | |
| CCCL C Parallel Library | |
| Catch2Helper |
🏃 Runner counts (total jobs: 32)
| # | Runner |
|---|---|
| 17 | linux-amd64-cpu16 |
| 6 | linux-amd64-gpu-rtx2080-latest-1 |
| 4 | windows-amd64-cpu16 |
| 4 | linux-arm64-cpu16 |
| 1 | linux-amd64-gpu-h100-latest-1 |
Contributor
Author
|
/ok to test b767ff9 |
Contributor
🟩 CI finished in 33m 32s: Pass: 100%/32 | Total: 3h 20m | Avg: 6m 16s | Max: 17m 25s | Hits: 94%/16022
|
| Project | |
|---|---|
| CCCL Infrastructure | |
| CCCL Packaging | |
| libcu++ | |
| CUB | |
| Thrust | |
| +/- | CUDA Experimental |
| stdpar | |
| python | |
| CCCL C Parallel Library | |
| Catch2Helper |
Modifications in project or dependencies?
| Project | |
|---|---|
| CCCL Infrastructure | |
| +/- | CCCL Packaging |
| libcu++ | |
| CUB | |
| Thrust | |
| +/- | CUDA Experimental |
| stdpar | |
| python | |
| CCCL C Parallel Library | |
| Catch2Helper |
🏃 Runner counts (total jobs: 32)
| # | Runner |
|---|---|
| 17 | linux-amd64-cpu16 |
| 6 | linux-amd64-gpu-rtx2080-latest-1 |
| 4 | windows-amd64-cpu16 |
| 4 | linux-arm64-cpu16 |
| 1 | linux-amd64-gpu-h100-latest-1 |
Contributor
🟩 CI finished in 25m 09s: Pass: 100%/32 | Total: 4h 14m | Avg: 7m 56s | Max: 16m 39s | Hits: 80%/16022
|
| Project | |
|---|---|
| CCCL Infrastructure | |
| CCCL Packaging | |
| libcu++ | |
| CUB | |
| Thrust | |
| +/- | CUDA Experimental |
| stdpar | |
| python | |
| CCCL C Parallel Library | |
| Catch2Helper |
Modifications in project or dependencies?
| Project | |
|---|---|
| CCCL Infrastructure | |
| +/- | CCCL Packaging |
| libcu++ | |
| CUB | |
| Thrust | |
| +/- | CUDA Experimental |
| stdpar | |
| python | |
| CCCL C Parallel Library | |
| Catch2Helper |
🏃 Runner counts (total jobs: 32)
| # | Runner |
|---|---|
| 17 | linux-amd64-cpu16 |
| 6 | linux-amd64-gpu-rtx2080-latest-1 |
| 4 | windows-amd64-cpu16 |
| 4 | linux-arm64-cpu16 |
| 1 | linux-amd64-gpu-h100-latest-1 |
miscco
approved these changes
Jun 27, 2025
Contributor
Contributor
Author
|
/ok to test c9bd3d1 |
Contributor
🟩 CI finished in 20m 54s: Pass: 100%/32 | Total: 3h 53m | Avg: 7m 16s | Max: 14m 37s | Hits: 85%/16022
|
| Project | |
|---|---|
| CCCL Infrastructure | |
| CCCL Packaging | |
| libcu++ | |
| CUB | |
| Thrust | |
| +/- | CUDA Experimental |
| stdpar | |
| python | |
| CCCL C Parallel Library | |
| Catch2Helper |
Modifications in project or dependencies?
| Project | |
|---|---|
| CCCL Infrastructure | |
| +/- | CCCL Packaging |
| libcu++ | |
| CUB | |
| Thrust | |
| +/- | CUDA Experimental |
| stdpar | |
| python | |
| CCCL C Parallel Library | |
| Catch2Helper |
🏃 Runner counts (total jobs: 32)
| # | Runner |
|---|---|
| 17 | linux-amd64-cpu16 |
| 6 | linux-amd64-gpu-rtx2080-latest-1 |
| 4 | windows-amd64-cpu16 |
| 4 | linux-arm64-cpu16 |
| 1 | linux-amd64-gpu-h100-latest-1 |
This was referenced Jun 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
when using the sender algorithms in
cudax::execution, the qualified type names that appear in diagnostics are very long and hard to read. this PR improves the situation in two ways:SCARY receivers
a major contributor to that is the idiom of using a reference to an opstate as a receiver with the help of the
__rcvr_refutility. the member functions that would ordinarily go on the receiver are put instead on the operation state. it saves a little boilerplate.the problem with doing that is that the types of operation states depend on the type of the sender used to create them. the receivers that the operation state uses do not need to depend on the sender type. by using a reference to the opstate as a receiver, the sender is part of the receiver type, resulting in massive duplication.
the end result is type names like:
when really all that is needed is:
this PR factors receivers out of the operation states and removes the receivers' dependence on the sender type.
Shared algorithm implementations
many of the algorithms (
just,then,let_value) come in value, error, and stopped variants. currently, these algorithm families share an implementation.just_tis actually an alias for__just_t<__disposition_t::__value>, and -- when displayed in a diagnostic -- then name of thejust(42)sender is something like:this PR changes things so that the type of
just(42)is:Checklist