Repository navigation
Fix segfault when compiling env - #4891
Merged
Merged
Conversation
ericniebler
approved these changes
Jun 4, 2025
ericniebler
reviewed
Jun 4, 2025
Comment on lines
+310
to
+311
| _Env0 __env0_; | ||
| _Env1 __env1_; |
Contributor
There was a problem hiding this comment.
we could still get the space savings if we switch to using EBO. s'thing like:
template <class _Env0, class _Env1>
struct env<_Env0, _Env1> : _Env0, _Env1
{
...
};
template <class _Env>
struct env<_Env, _Env> : _Env
{
_Env __env_;
...
};
Contributor
There was a problem hiding this comment.
That has a ton of minor issues, considering there is nothing preventing an env from being final and we would also need _CCCL_DECLSPEC_EMPTY_BASES on any of those
I believe we need a proper EBCO implementation that extents what I did for mdspan in libcudacxx/include/cuda/std/__mdspan/empty_base.h
Collaborator
Author
There was a problem hiding this comment.
Ok, given that I need this sooner, I'll merge the fix and we can optimize storage as a follow up.
Contributor
🟩 CI finished in 1h 25m: Pass: 100%/187 | Total: 1d 10h | Avg: 11m 04s | Max: 52m 31s | Hits: 96%/293756
|
| Project | |
|---|---|
| CCCL Infrastructure | |
| CCCL Packaging | |
| +/- | libcu++ |
| CUB | |
| Thrust | |
| CUDA Experimental | |
| stdpar | |
| python | |
| CCCL C Parallel Library | |
| Catch2Helper |
Modifications in project or dependencies?
| Project | |
|---|---|
| CCCL Infrastructure | |
| +/- | CCCL Packaging |
| +/- | libcu++ |
| +/- | CUB |
| +/- | Thrust |
| +/- | CUDA Experimental |
| +/- | stdpar |
| +/- | python |
| +/- | CCCL C Parallel Library |
| +/- | Catch2Helper |
🏃 Runner counts (total jobs: 187)
| # | Runner |
|---|---|
| 129 | linux-amd64-cpu16 |
| 15 | windows-amd64-cpu16 |
| 12 | linux-arm64-cpu16 |
| 12 | linux-amd64-gpu-rtxa6000-latest-1 |
| 11 | linux-amd64-gpu-rtx2080-latest-1 |
| 5 | linux-amd64-gpu-h100-latest-1 |
| 3 | linux-amd64-gpu-rtx4090-latest-1 |
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
#4871 follow up
Checklist