Repository navigation
Port functional_placeholders_logical Thrust test to Catch2 - #4882
Merged
bernhardmgruber merged 1 commit intoJun 3, 2025
Merged
Conversation
Contributor
ðĐ CI finished in 1h 22m: Pass: 100%/130 | Total: 1d 00h | Avg: 11m 16s | Max: 40m 38s | Hits: 99%/162899
|
| Project | |
|---|---|
| CCCL Infrastructure | |
| CCCL Packaging | |
| libcu++ | |
| CUB | |
| +/- | Thrust |
| CUDA Experimental | |
| stdpar | |
| python | |
| CCCL C Parallel Library | |
| Catch2Helper |
Modifications in project or dependencies?
| Project | |
|---|---|
| CCCL Infrastructure | |
| +/- | CCCL Packaging |
| libcu++ | |
| +/- | CUB |
| +/- | Thrust |
| +/- | CUDA Experimental |
| +/- | stdpar |
| python | |
| +/- | CCCL C Parallel Library |
| +/- | Catch2Helper |
ðâ Runner counts (total jobs: 130)
| # | Runner |
|---|---|
| 89 | linux-amd64-cpu16 |
| 11 | windows-amd64-cpu16 |
| 10 | linux-arm64-cpu16 |
| 7 | linux-amd64-gpu-rtx2080-latest-1 |
| 6 | linux-amd64-gpu-rtxa6000-latest-1 |
| 4 | linux-amd64-gpu-h100-latest-1 |
| 3 | linux-amd64-gpu-rtx4090-latest-1 |
miscco
reviewed
Jun 3, 2025
| if (input.size() > 0) | ||
| { | ||
| // produce at least one true in the output | ||
| input[0] = T(0); |
Contributor
There was a problem hiding this comment.
Nitpick: Dont we rebing integers to bool, so 0 would be false?
Contributor
Author
There was a problem hiding this comment.
I took this over from the previous test. I could imagine that random_samples does not return any zero, so this code just makes sure zero is part of the input data set.
The test later just logically negates all values, so a zero, would result in false, which would be negated to true. So the comment and code here seems good to me.
miscco
approved these changes
Jun 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.