Skip to content

Refactor cuda::std::rot* - #4488

Merged
miscco merged 1 commit into
NVIDIA:mainfrom
davebayer:refactor_rotate
Apr 17, 2025
Merged

miscco merged 1 commit into
NVIDIA:mainfrom
davebayer:refactor_rotate

Conversation

@davebayer

Copy link
Copy Markdown
Contributor

This PR implements a minor refactor cuda::std::rot* functions and improves the handling of a corner case when the rotation_count == INT_MIN.

@davebayer
davebayer requested a review from a team as a code owner April 17, 2025 07:07
@github-project-automation github-project-automation Bot moved this to Todo in CCCL Apr 17, 2025
@copy-pr-bot

copy-pr-bot Bot commented Apr 17, 2025

Copy link
Copy Markdown
Contributor

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@cccl-authenticator-app cccl-authenticator-app Bot moved this from Todo to In Review in CCCL Apr 17, 2025
@miscco

miscco commented Apr 17, 2025

Copy link
Copy Markdown
Contributor

/ok to test d4a5889

@github-actions

Copy link
Copy Markdown
Contributor
ðŸŸĐ CI finished in 2h 12m: Pass: 100%/174 | Total: 3d 12h | Avg: 29m 00s | Max: 1h 25m | Hits: 76%/271185
  • ðŸŸĐ cub: Pass: 100%/47 | Total: 1d 23h | Avg: 1h 00m | Max: 1h 25m | Hits: 48%/56545

    ðŸŸĐ cpu
      ðŸŸĐ amd64              Pass: 100%/45  | Total:  1d 20h | Avg: 59m 57s | Max:  1h 25m | Hits:  48%/54087 
      ðŸŸĐ arm64              Pass: 100%/2   | Total:  2h 15m | Avg:  1h 07m | Max:  1h 09m | Hits:  37%/2458  
    ðŸŸĐ ctk
      ðŸŸĐ 12.0               Pass: 100%/5   | Total:  5h 41m | Avg:  1h 08m | Max:  1h 16m | Hits:  37%/5974  
      ðŸŸĐ 12.8               Pass: 100%/42  | Total:  1d 17h | Avg: 59m 19s | Max:  1h 25m | Hits:  49%/50571 
    ðŸŸĐ cudacxx
      ðŸŸĐ ClangCUDA19        Pass: 100%/2   | Total:  1h 58m | Avg: 59m 01s | Max: 59m 06s | Hits:  38%/2120  
      ðŸŸĐ nvcc12.0           Pass: 100%/5   | Total:  5h 41m | Avg:  1h 08m | Max:  1h 16m | Hits:  37%/5974  
      ðŸŸĐ nvcc12.8           Pass: 100%/40  | Total:  1d 15h | Avg: 59m 20s | Max:  1h 25m | Hits:  49%/48451 
    ðŸŸĐ cudacxx_family
      ðŸŸĐ ClangCUDA          Pass: 100%/2   | Total:  1h 58m | Avg: 59m 01s | Max: 59m 06s | Hits:  38%/2120  
      ðŸŸĐ nvcc               Pass: 100%/45  | Total:  1d 21h | Avg:  1h 00m | Max:  1h 25m | Hits:  48%/54425 
    ðŸŸĐ cxx
      ðŸŸĐ Clang14            Pass: 100%/4   | Total:  4h 29m | Avg:  1h 07m | Max:  1h 10m | Hits:  37%/4924  
      ðŸŸĐ Clang15            Pass: 100%/2   | Total:  2h 06m | Avg:  1h 03m | Max:  1h 03m | Hits:  37%/2458  
      ðŸŸĐ Clang16            Pass: 100%/2   | Total:  2h 09m | Avg:  1h 04m | Max:  1h 07m | Hits:  37%/2458  
      ðŸŸĐ Clang17            Pass: 100%/2   | Total:  2h 05m | Avg:  1h 02m | Max:  1h 03m | Hits:  37%/2458  
      ðŸŸĐ Clang18            Pass: 100%/2   | Total:  2h 11m | Avg:  1h 05m | Max:  1h 06m | Hits:  37%/2458  
      ðŸŸĐ Clang19            Pass: 100%/7   | Total:  6h 05m | Avg: 52m 15s | Max:  1h 06m | Hits:  56%/8265  
      ðŸŸĐ GCC7               Pass: 100%/2   | Total:  2h 23m | Avg:  1h 11m | Max:  1h 16m | Hits:  37%/2462  
      ðŸŸĐ GCC8               Pass: 100%/1   | Total:  1h 06m | Avg:  1h 06m | Max:  1h 06m | Hits:  37%/1231  
      ðŸŸĐ GCC9               Pass: 100%/2   | Total:  2h 20m | Avg:  1h 10m | Max:  1h 13m | Hits:  37%/2462  
      ðŸŸĐ GCC10              Pass: 100%/2   | Total:  2h 12m | Avg:  1h 06m | Max:  1h 06m | Hits:  37%/2462  
      ðŸŸĐ GCC11              Pass: 100%/2   | Total:  2h 15m | Avg:  1h 07m | Max:  1h 09m | Hits:  37%/2458  
      ðŸŸĐ GCC12              Pass: 100%/2   | Total:  2h 17m | Avg:  1h 08m | Max:  1h 12m | Hits:  37%/2458  
      ðŸŸĐ GCC13              Pass: 100%/11  | Total:  7h 43m | Avg: 42m 07s | Max:  1h 13m | Hits:  71%/13519 
      ðŸŸĐ MSVC14.29          Pass: 100%/2   | Total:  2h 29m | Avg:  1h 14m | Max:  1h 20m | Hits:  37%/2100  
      ðŸŸĐ MSVC14.42          Pass: 100%/2   | Total:  2h 43m | Avg:  1h 21m | Max:  1h 25m | Hits:  37%/2100  
      ðŸŸĐ NVHPC25.3          Pass: 100%/2   | Total:  2h 33m | Avg:  1h 16m | Max:  1h 18m | Hits:  34%/2272  
    ðŸŸĐ cxx_family
      ðŸŸĐ Clang              Pass: 100%/19  | Total: 19h 08m | Avg:  1h 00m | Max:  1h 10m | Hits:  44%/23021 
      ðŸŸĐ GCC                Pass: 100%/22  | Total: 20h 18m | Avg: 55m 22s | Max:  1h 16m | Hits:  54%/27052 
      ðŸŸĐ MSVC               Pass: 100%/4   | Total:  5h 12m | Avg:  1h 18m | Max:  1h 25m | Hits:  37%/4200  
      ðŸŸĐ NVHPC              Pass: 100%/2   | Total:  2h 33m | Avg:  1h 16m | Max:  1h 18m | Hits:  34%/2272  
    ðŸŸĐ gpu
      ðŸŸĐ h100               Pass: 100%/3   | Total:  1h 19m | Avg: 26m 30s | Max: 30m 54s | Hits:  78%/3687  
      ðŸŸĐ rtx2080            Pass: 100%/36  | Total:  1d 17h | Avg:  1h 08m | Max:  1h 25m | Hits:  37%/43026 
      ðŸŸĐ rtxa6000           Pass: 100%/8   | Total:  4h 51m | Avg: 36m 26s | Max:  1h 06m | Hits:  84%/9832  
    ðŸŸĐ jobs
      ðŸŸĐ Build              Pass: 100%/39  | Total:  1d 19h | Avg:  1h 07m | Max:  1h 25m | Hits:  37%/46713 
      ðŸŸĐ DeviceLaunch       Pass: 100%/1   | Total: 29m 21s | Avg: 29m 21s | Max: 29m 21s | Hits:  99%/1229  
      ðŸŸĐ GraphCapture       Pass: 100%/1   | Total: 23m 00s | Avg: 23m 00s | Max: 23m 00s | Hits:  99%/1229  
      ðŸŸĐ HostLaunch         Pass: 100%/3   | Total:  1h 24m | Avg: 28m 17s | Max: 29m 58s | Hits:  99%/3687  
      ðŸŸĐ TestGPU            Pass: 100%/3   | Total:  1h 13m | Avg: 24m 31s | Max: 26m 50s | Hits:  99%/3687  
    ðŸŸĐ sm
      ðŸŸĐ 90                 Pass: 100%/3   | Total:  1h 19m | Avg: 26m 30s | Max: 30m 54s | Hits:  78%/3687  
      ðŸŸĐ 90;90a;100         Pass: 100%/1   | Total:  1h 13m | Avg:  1h 13m | Max:  1h 13m | Hits:  37%/1229  
    ðŸŸĐ std
      ðŸŸĐ 17                 Pass: 100%/21  | Total:  1d 00h | Avg:  1h 08m | Max:  1h 20m | Hits:  37%/25026 
      ðŸŸĐ 20                 Pass: 100%/26  | Total: 23h 08m | Avg: 53m 24s | Max:  1h 25m | Hits:  56%/31519 
    
  • ðŸŸĐ thrust: Pass: 100%/47 | Total: 1d 00h | Avg: 31m 02s | Max: 1h 08m | Hits: 78%/83463

    ðŸŸĐ cmake_options
      ðŸŸĐ -DTHRUST_DISPATCH_TYPE=Force32bit Pass: 100%/2   | Total: 38m 09s | Avg: 19m 04s | Max: 26m 45s | Hits:  88%/3554  
    ðŸŸĐ cpu
      ðŸŸĐ amd64              Pass: 100%/45  | Total: 23h 23m | Avg: 31m 10s | Max:  1h 08m | Hits:  78%/79910 
      ðŸŸĐ arm64              Pass: 100%/2   | Total: 55m 58s | Avg: 27m 59s | Max: 29m 54s | Hits:  77%/3553  
    ðŸŸĐ ctk
      ðŸŸĐ 12.0               Pass: 100%/5   | Total:  3h 02m | Avg: 36m 25s | Max: 54m 41s | Hits:  74%/8876  
      ðŸŸĐ 12.8               Pass: 100%/42  | Total: 21h 17m | Avg: 30m 24s | Max:  1h 08m | Hits:  79%/74587 
    ðŸŸĐ cudacxx
      ðŸŸĐ ClangCUDA19        Pass: 100%/2   | Total: 48m 52s | Avg: 24m 26s | Max: 24m 36s | Hits:  77%/3552  
      ðŸŸĐ nvcc12.0           Pass: 100%/5   | Total:  3h 02m | Avg: 36m 25s | Max: 54m 41s | Hits:  74%/8876  
      ðŸŸĐ nvcc12.8           Pass: 100%/40  | Total: 20h 28m | Avg: 30m 42s | Max:  1h 08m | Hits:  79%/71035 
    ðŸŸĐ cudacxx_family
      ðŸŸĐ ClangCUDA          Pass: 100%/2   | Total: 48m 52s | Avg: 24m 26s | Max: 24m 36s | Hits:  77%/3552  
      ðŸŸĐ nvcc               Pass: 100%/45  | Total: 23h 30m | Avg: 31m 20s | Max:  1h 08m | Hits:  78%/79911 
    ðŸŸĐ cxx
      ðŸŸĐ Clang14            Pass: 100%/4   | Total:  1h 59m | Avg: 29m 48s | Max: 32m 06s | Hits:  77%/7104  
      ðŸŸĐ Clang15            Pass: 100%/2   | Total:  1h 00m | Avg: 30m 00s | Max: 31m 01s | Hits:  77%/3552  
      ðŸŸĐ Clang16            Pass: 100%/2   | Total:  1h 02m | Avg: 31m 20s | Max: 32m 35s | Hits:  77%/3552  
      ðŸŸĐ Clang17            Pass: 100%/2   | Total:  1h 01m | Avg: 30m 53s | Max: 31m 01s | Hits:  77%/3552  
      ðŸŸĐ Clang18            Pass: 100%/2   | Total: 58m 14s | Avg: 29m 07s | Max: 29m 45s | Hits:  77%/3552  
      ðŸŸĐ Clang19            Pass: 100%/7   | Total:  2h 35m | Avg: 22m 14s | Max: 32m 15s | Hits:  83%/12432 
      ðŸŸĐ GCC7               Pass: 100%/2   | Total:  1h 03m | Avg: 31m 37s | Max: 33m 34s | Hits:  76%/3554  
      ðŸŸĐ GCC8               Pass: 100%/1   | Total: 29m 27s | Avg: 29m 27s | Max: 29m 27s | Hits:  76%/1777  
      ðŸŸĐ GCC9               Pass: 100%/2   | Total:  1h 05m | Avg: 32m 43s | Max: 33m 15s | Hits:  76%/3554  
      ðŸŸĐ GCC10              Pass: 100%/2   | Total:  1h 02m | Avg: 31m 06s | Max: 31m 33s | Hits:  76%/3554  
      ðŸŸĐ GCC11              Pass: 100%/2   | Total:  1h 02m | Avg: 31m 17s | Max: 31m 50s | Hits:  76%/3554  
      ðŸŸĐ GCC12              Pass: 100%/2   | Total:  1h 02m | Avg: 31m 06s | Max: 31m 46s | Hits:  76%/3554  
      ðŸŸĐ GCC13              Pass: 100%/10  | Total:  3h 34m | Avg: 21m 27s | Max: 33m 54s | Hits:  86%/17770 
      ðŸŸĐ MSVC14.29          Pass: 100%/2   | Total:  1h 46m | Avg: 53m 25s | Max: 54m 41s | Hits:  64%/3540  
      ðŸŸĐ MSVC14.42          Pass: 100%/3   | Total:  2h 23m | Avg: 47m 50s | Max: 59m 23s | Hits:  76%/5310  
      ðŸŸĐ NVHPC25.3          Pass: 100%/2   | Total:  2h 11m | Avg:  1h 05m | Max:  1h 08m | Hits:  64%/3552  
    ðŸŸĐ cxx_family
      ðŸŸĐ Clang              Pass: 100%/19  | Total:  8h 37m | Avg: 27m 14s | Max: 32m 35s | Hits:  79%/33744 
      ðŸŸĐ GCC                Pass: 100%/21  | Total:  9h 19m | Avg: 26m 38s | Max: 33m 54s | Hits:  81%/37317 
      ðŸŸĐ MSVC               Pass: 100%/5   | Total:  4h 10m | Avg: 50m 04s | Max: 59m 23s | Hits:  71%/8850  
      ðŸŸĐ NVHPC              Pass: 100%/2   | Total:  2h 11m | Avg:  1h 05m | Max:  1h 08m | Hits:  64%/3552  
    ðŸŸĐ gpu
      ðŸŸĐ h100               Pass: 100%/2   | Total: 28m 22s | Avg: 14m 11s | Max: 16m 26s | Hits:  88%/3554  
      ðŸŸĐ rtx2080            Pass: 100%/35  | Total: 20h 04m | Avg: 34m 24s | Max:  1h 08m | Hits:  75%/62156 
      ðŸŸĐ rtx4090            Pass: 100%/10  | Total:  3h 46m | Avg: 22m 37s | Max: 56m 05s | Hits:  89%/17753 
    ðŸŸĐ jobs
      ðŸŸĐ Build              Pass: 100%/40  | Total: 22h 49m | Avg: 34m 14s | Max:  1h 08m | Hits:  75%/71033 
      ðŸŸĐ TestCPU            Pass: 100%/3   | Total: 43m 40s | Avg: 14m 33s | Max: 28m 03s | Hits:  99%/5323  
      ðŸŸĐ TestGPU            Pass: 100%/4   | Total: 45m 29s | Avg: 11m 22s | Max: 11m 56s | Hits:  99%/7107  
    ðŸŸĐ sm
      ðŸŸĐ 90                 Pass: 100%/2   | Total: 28m 22s | Avg: 14m 11s | Max: 16m 26s | Hits:  88%/3554  
      ðŸŸĐ 90;90a;100         Pass: 100%/1   | Total: 33m 47s | Avg: 33m 47s | Max: 33m 47s | Hits:  76%/1777  
    ðŸŸĐ std
      ðŸŸĐ 17                 Pass: 100%/21  | Total: 12h 36m | Avg: 36m 00s | Max:  1h 08m | Hits:  74%/37287 
      ðŸŸĐ 20                 Pass: 100%/24  | Total: 11h 04m | Avg: 27m 41s | Max:  1h 03m | Hits:  81%/42622 
    
  • ðŸŸĐ libcudacxx: Pass: 100%/45 | Total: 8h 08m | Avg: 10m 51s | Max: 30m 27s | Hits: 87%/116267

    ðŸŸĐ cpu
      ðŸŸĐ amd64              Pass: 100%/43  | Total:  7h 55m | Avg: 11m 03s | Max: 30m 27s | Hits:  87%/110236
      ðŸŸĐ arm64              Pass: 100%/2   | Total: 13m 34s | Avg:  6m 47s | Max:  7m 09s | Hits:  91%/6031  
    ðŸŸĐ ctk
      ðŸŸĐ 12.0               Pass: 100%/5   | Total: 47m 48s | Avg:  9m 33s | Max: 22m 27s | Hits:  92%/14694 
      ðŸŸĐ 12.8               Pass: 100%/40  | Total:  7h 21m | Avg: 11m 01s | Max: 30m 27s | Hits:  86%/101573
    ðŸŸĐ cudacxx
      ðŸŸĐ ClangCUDA19        Pass: 100%/2   | Total: 47m 03s | Avg: 23m 31s | Max: 25m 37s | Hits:  27%/5991  
      ðŸŸĐ nvcc12.0           Pass: 100%/5   | Total: 47m 48s | Avg:  9m 33s | Max: 22m 27s | Hits:  92%/14694 
      ðŸŸĐ nvcc12.8           Pass: 100%/38  | Total:  6h 33m | Avg: 10m 22s | Max: 30m 27s | Hits:  90%/95582 
    ðŸŸĐ cudacxx_family
      ðŸŸĐ ClangCUDA          Pass: 100%/2   | Total: 47m 03s | Avg: 23m 31s | Max: 25m 37s | Hits:  27%/5991  
      ðŸŸĐ nvcc               Pass: 100%/43  | Total:  7h 21m | Avg: 10m 16s | Max: 30m 27s | Hits:  90%/110276
    ðŸŸĐ cxx
      ðŸŸĐ Clang14            Pass: 100%/4   | Total: 27m 26s | Avg:  6m 51s | Max:  7m 17s | Hits:  92%/11950 
      ðŸŸĐ Clang15            Pass: 100%/2   | Total: 14m 49s | Avg:  7m 24s | Max:  7m 31s | Hits:  93%/5987  
      ðŸŸĐ Clang16            Pass: 100%/2   | Total: 14m 58s | Avg:  7m 29s | Max:  7m 42s | Hits:  93%/5987  
      ðŸŸĐ Clang17            Pass: 100%/2   | Total: 15m 49s | Avg:  7m 54s | Max:  8m 04s | Hits:  93%/5987  
      ðŸŸĐ Clang18            Pass: 100%/2   | Total: 18m 02s | Avg:  9m 01s | Max: 10m 47s | Hits:  87%/5987  
      ðŸŸĐ Clang19            Pass: 100%/6   | Total:  1h 17m | Avg: 12m 56s | Max: 25m 37s | Hits:  66%/14993 
      ðŸŸĐ GCC7               Pass: 100%/2   | Total: 12m 53s | Avg:  6m 26s | Max:  6m 46s | Hits:  93%/5923  
      ðŸŸĐ GCC8               Pass: 100%/1   | Total:  6m 01s | Avg:  6m 01s | Max:  6m 01s | Hits:  93%/2972  
      ðŸŸĐ GCC9               Pass: 100%/2   | Total: 13m 15s | Avg:  6m 37s | Max:  6m 56s | Hits:  93%/5935  
      ðŸŸĐ GCC10              Pass: 100%/2   | Total: 17m 56s | Avg:  8m 58s | Max: 10m 20s | Hits:  87%/5993  
      ðŸŸĐ GCC11              Pass: 100%/2   | Total: 13m 51s | Avg:  6m 55s | Max:  7m 06s | Hits:  92%/5989  
      ðŸŸĐ GCC12              Pass: 100%/2   | Total: 18m 12s | Avg:  9m 06s | Max: 10m 40s | Hits:  87%/5989  
      ðŸŸĐ GCC13              Pass: 100%/10  | Total:  1h 34m | Avg:  9m 26s | Max: 17m 51s | Hits:  91%/15255 
      ðŸŸĐ MSVC14.29          Pass: 100%/2   | Total: 46m 55s | Avg: 23m 27s | Max: 24m 28s | Hits:  90%/5635  
      ðŸŸĐ MSVC14.42          Pass: 100%/2   | Total: 53m 04s | Avg: 26m 32s | Max: 26m 48s | Hits:  92%/5708  
      ðŸŸĐ NVHPC25.3          Pass: 100%/2   | Total: 43m 40s | Avg: 21m 50s | Max: 30m 27s | Hits:  68%/5977  
    ðŸŸĐ cxx_family
      ðŸŸĐ Clang              Pass: 100%/18  | Total:  2h 48m | Avg:  9m 22s | Max: 25m 37s | Hits:  84%/50891 
      ðŸŸĐ GCC                Pass: 100%/21  | Total:  2h 56m | Avg:  8m 24s | Max: 17m 51s | Hits:  91%/48056 
      ðŸŸĐ MSVC               Pass: 100%/4   | Total:  1h 39m | Avg: 24m 59s | Max: 26m 48s | Hits:  91%/11343 
      ðŸŸĐ NVHPC              Pass: 100%/2   | Total: 43m 40s | Avg: 21m 50s | Max: 30m 27s | Hits:  68%/5977  
    ðŸŸĐ gpu
      ðŸŸĐ h100               Pass: 100%/2   | Total: 17m 50s | Avg:  8m 55s | Max: 12m 26s | Hits:  93%/3105  
      ðŸŸĐ rtx2080            Pass: 100%/43  | Total:  7h 51m | Avg: 10m 57s | Max: 30m 27s | Hits:  87%/113162
    ðŸŸĐ jobs
      ðŸŸĐ Build              Pass: 100%/39  | Total:  6h 59m | Avg: 10m 45s | Max: 30m 27s | Hits:  87%/116227
      ðŸŸĐ NVRTC              Pass: 100%/2   | Total: 34m 34s | Avg: 17m 17s | Max: 17m 51s | Hits:  90%/40    
      ðŸŸĐ Test               Pass: 100%/3   | Total: 32m 08s | Avg: 10m 42s | Max: 12m 26s
      ðŸŸĐ VerifyCodegen      Pass: 100%/1   | Total:  2m 16s | Avg:  2m 16s | Max:  2m 16s
    ðŸŸĐ sm
      ðŸŸĐ 75                 Pass: 100%/2   | Total: 34m 34s | Avg: 17m 17s | Max: 17m 51s | Hits:  90%/40    
      ðŸŸĐ 90                 Pass: 100%/2   | Total: 17m 50s | Avg:  8m 55s | Max: 12m 26s | Hits:  93%/3105  
      ðŸŸĐ 90;90a;100         Pass: 100%/1   | Total:  8m 42s | Avg:  8m 42s | Max:  8m 42s | Hits:  90%/3105  
    ðŸŸĐ std
      ðŸŸĐ 17                 Pass: 100%/22  | Total:  3h 57m | Avg: 10m 46s | Max: 26m 16s | Hits:  89%/61936 
      ðŸŸĐ 20                 Pass: 100%/22  | Total:  4h 09m | Avg: 11m 20s | Max: 30m 27s | Hits:  84%/54331 
    
  • ðŸŸĐ cudax: Pass: 100%/26 | Total: 3h 06m | Avg: 7m 11s | Max: 17m 59s | Hits: 90%/14592

    ðŸŸĐ cpu
      ðŸŸĐ amd64              Pass: 100%/22  | Total:  2h 47m | Avg:  7m 36s | Max: 17m 59s | Hits:  90%/12256 
      ðŸŸĐ arm64              Pass: 100%/4   | Total: 19m 28s | Avg:  4m 52s | Max:  5m 18s | Hits:  90%/2336  
    ðŸŸĐ ctk
      ðŸŸĐ 12.0               Pass: 100%/3   | Total: 21m 46s | Avg:  7m 15s | Max: 11m 41s | Hits:  87%/1458  
      ðŸŸĐ 12.8               Pass: 100%/23  | Total:  2h 45m | Avg:  7m 10s | Max: 17m 59s | Hits:  91%/13134 
    ðŸŸĐ cudacxx
      ðŸŸĐ nvcc12.0           Pass: 100%/3   | Total: 21m 46s | Avg:  7m 15s | Max: 11m 41s | Hits:  87%/1458  
      ðŸŸĐ nvcc12.8           Pass: 100%/23  | Total:  2h 45m | Avg:  7m 10s | Max: 17m 59s | Hits:  91%/13134 
    ðŸŸĐ cudacxx_family
      ðŸŸĐ nvcc               Pass: 100%/26  | Total:  3h 06m | Avg:  7m 11s | Max: 17m 59s | Hits:  90%/14592 
    ðŸŸĐ cxx
      ðŸŸĐ Clang14            Pass: 100%/2   | Total:  9m 53s | Avg:  4m 56s | Max:  5m 13s | Hits:  90%/1172  
      ðŸŸĐ Clang15            Pass: 100%/1   | Total:  5m 32s | Avg:  5m 32s | Max:  5m 32s | Hits:  90%/584   
      ðŸŸĐ Clang16            Pass: 100%/1   | Total:  5m 23s | Avg:  5m 23s | Max:  5m 23s | Hits:  90%/584   
      ðŸŸĐ Clang17            Pass: 100%/1   | Total:  5m 35s | Avg:  5m 35s | Max:  5m 35s | Hits:  90%/584   
      ðŸŸĐ Clang18            Pass: 100%/1   | Total:  5m 12s | Avg:  5m 12s | Max:  5m 12s | Hits:  90%/584   
      ðŸŸĐ Clang19            Pass: 100%/4   | Total: 28m 08s | Avg:  7m 02s | Max: 13m 24s | Hits:  92%/2336  
      ðŸŸĐ GCC10              Pass: 100%/2   | Total: 11m 24s | Avg:  5m 42s | Max:  5m 59s | Hits:  90%/1172  
      ðŸŸĐ GCC11              Pass: 100%/1   | Total:  5m 38s | Avg:  5m 38s | Max:  5m 38s | Hits:  90%/584   
      ðŸŸĐ GCC12              Pass: 100%/1   | Total:  5m 52s | Avg:  5m 52s | Max:  5m 52s | Hits:  90%/584   
      ðŸŸĐ GCC13              Pass: 100%/8   | Total: 59m 12s | Avg:  7m 24s | Max: 17m 59s | Hits:  92%/4672  
      ðŸŸĐ MSVC14.39          Pass: 100%/1   | Total: 11m 41s | Avg: 11m 41s | Max: 11m 41s | Hits:  77%/286   
      ðŸŸĐ MSVC14.42          Pass: 100%/1   | Total: 12m 02s | Avg: 12m 02s | Max: 12m 02s | Hits:  77%/286   
      ðŸŸĐ NVHPC25.3          Pass: 100%/2   | Total: 21m 19s | Avg: 10m 39s | Max: 10m 47s | Hits:  87%/1164  
    ðŸŸĐ cxx_family
      ðŸŸĐ Clang              Pass: 100%/10  | Total: 59m 43s | Avg:  5m 58s | Max: 13m 24s | Hits:  91%/5844  
      ðŸŸĐ GCC                Pass: 100%/12  | Total:  1h 22m | Avg:  6m 50s | Max: 17m 59s | Hits:  91%/7012  
      ðŸŸĐ MSVC               Pass: 100%/2   | Total: 23m 43s | Avg: 11m 51s | Max: 12m 02s | Hits:  77%/572   
      ðŸŸĐ NVHPC              Pass: 100%/2   | Total: 21m 19s | Avg: 10m 39s | Max: 10m 47s | Hits:  87%/1164  
    ðŸŸĐ gpu
      ðŸŸĐ h100               Pass: 100%/2   | Total: 16m 24s | Avg:  8m 12s | Max: 11m 31s | Hits:  94%/1168  
      ðŸŸĐ rtx2080            Pass: 100%/24  | Total:  2h 50m | Avg:  7m 06s | Max: 17m 59s | Hits:  90%/13424 
    ðŸŸĐ jobs
      ðŸŸĐ Build              Pass: 100%/23  | Total:  2h 23m | Avg:  6m 15s | Max: 12m 02s | Hits:  89%/12840 
      ðŸŸĐ Test               Pass: 100%/3   | Total: 42m 54s | Avg: 14m 18s | Max: 17m 59s | Hits:  99%/1752  
    ðŸŸĐ sm
      ðŸŸĐ 90                 Pass: 100%/3   | Total: 20m 37s | Avg:  6m 52s | Max: 11m 31s | Hits:  93%/1752  
      ðŸŸĐ 90a                Pass: 100%/1   | Total:  4m 24s | Avg:  4m 24s | Max:  4m 24s | Hits:  90%/584   
    ðŸŸĐ std
      ðŸŸĐ 17                 Pass: 100%/4   | Total: 24m 15s | Avg:  6m 03s | Max: 10m 32s | Hits:  89%/2334  
      ðŸŸĐ 20                 Pass: 100%/22  | Total:  2h 42m | Avg:  7m 23s | Max: 17m 59s | Hits:  90%/12258 
    
  • ðŸŸĐ stdpar: Pass: 100%/4 | Total: 20m 21s | Avg: 5m 05s | Max: 6m 06s

    ðŸŸĐ cpu
      ðŸŸĐ amd64              Pass: 100%/2   | Total: 11m 47s | Avg:  5m 53s | Max:  6m 06s
      ðŸŸĐ arm64              Pass: 100%/2   | Total:  8m 34s | Avg:  4m 17s | Max:  4m 20s
    ðŸŸĐ ctk
      ðŸŸĐ 12.8               Pass: 100%/4   | Total: 20m 21s | Avg:  5m 05s | Max:  6m 06s
    ðŸŸĐ cudacxx
      ðŸŸĐ nvcc12.8           Pass: 100%/4   | Total: 20m 21s | Avg:  5m 05s | Max:  6m 06s
    ðŸŸĐ cudacxx_family
      ðŸŸĐ nvcc               Pass: 100%/4   | Total: 20m 21s | Avg:  5m 05s | Max:  6m 06s
    ðŸŸĐ cxx
      ðŸŸĐ NVHPC25.3          Pass: 100%/4   | Total: 20m 21s | Avg:  5m 05s | Max:  6m 06s
    ðŸŸĐ cxx_family
      ðŸŸĐ NVHPC              Pass: 100%/4   | Total: 20m 21s | Avg:  5m 05s | Max:  6m 06s
    ðŸŸĐ gpu
      ðŸŸĐ rtx2080            Pass: 100%/4   | Total: 20m 21s | Avg:  5m 05s | Max:  6m 06s
    ðŸŸĐ jobs
      ðŸŸĐ Build              Pass: 100%/4   | Total: 20m 21s | Avg:  5m 05s | Max:  6m 06s
    ðŸŸĐ std
      ðŸŸĐ 17                 Pass: 100%/2   | Total:  9m 55s | Avg:  4m 57s | Max:  5m 41s
      ðŸŸĐ 20                 Pass: 100%/2   | Total: 10m 26s | Avg:  5m 13s | Max:  6m 06s
    
  • ðŸŸĐ python: Pass: 100%/3 | Total: 33m 28s | Avg: 11m 09s | Max: 18m 19s

    ðŸŸĐ cpu
      ðŸŸĐ amd64              Pass: 100%/3   | Total: 33m 28s | Avg: 11m 09s | Max: 18m 19s
    ðŸŸĐ ctk
      ðŸŸĐ 12.8               Pass: 100%/3   | Total: 33m 28s | Avg: 11m 09s | Max: 18m 19s
    ðŸŸĐ cudacxx
      ðŸŸĐ nvcc12.8           Pass: 100%/3   | Total: 33m 28s | Avg: 11m 09s | Max: 18m 19s
    ðŸŸĐ cudacxx_family
      ðŸŸĐ nvcc               Pass: 100%/3   | Total: 33m 28s | Avg: 11m 09s | Max: 18m 19s
    ðŸŸĐ cxx
      ðŸŸĐ GCC13              Pass: 100%/3   | Total: 33m 28s | Avg: 11m 09s | Max: 18m 19s
    ðŸŸĐ cxx_family
      ðŸŸĐ GCC                Pass: 100%/3   | Total: 33m 28s | Avg: 11m 09s | Max: 18m 19s
    ðŸŸĐ gpu
      ðŸŸĐ rtx2080            Pass: 100%/3   | Total: 33m 28s | Avg: 11m 09s | Max: 18m 19s
    ðŸŸĐ jobs
      ðŸŸĐ cuda.cccl          Pass: 100%/1   | Total:  3m 26s | Avg:  3m 26s | Max:  3m 26s
      ðŸŸĐ cuda.cooperative   Pass: 100%/1   | Total: 18m 19s | Avg: 18m 19s | Max: 18m 19s
      ðŸŸĐ cuda.parallel      Pass: 100%/1   | Total: 11m 43s | Avg: 11m 43s | Max: 11m 43s
    
  • ðŸŸĐ cccl_c_parallel: Pass: 100%/2 | Total: 26m 45s | Avg: 13m 22s | Max: 23m 22s | Hits: 94%/318

    ðŸŸĐ cpu
      ðŸŸĐ amd64              Pass: 100%/2   | Total: 26m 45s | Avg: 13m 22s | Max: 23m 22s | Hits:  94%/318   
    ðŸŸĐ ctk
      ðŸŸĐ 12.8               Pass: 100%/2   | Total: 26m 45s | Avg: 13m 22s | Max: 23m 22s | Hits:  94%/318   
    ðŸŸĐ cudacxx
      ðŸŸĐ nvcc12.8           Pass: 100%/2   | Total: 26m 45s | Avg: 13m 22s | Max: 23m 22s | Hits:  94%/318   
    ðŸŸĐ cudacxx_family
      ðŸŸĐ nvcc               Pass: 100%/2   | Total: 26m 45s | Avg: 13m 22s | Max: 23m 22s | Hits:  94%/318   
    ðŸŸĐ cxx
      ðŸŸĐ GCC13              Pass: 100%/2   | Total: 26m 45s | Avg: 13m 22s | Max: 23m 22s | Hits:  94%/318   
    ðŸŸĐ cxx_family
      ðŸŸĐ GCC                Pass: 100%/2   | Total: 26m 45s | Avg: 13m 22s | Max: 23m 22s | Hits:  94%/318   
    ðŸŸĐ gpu
      ðŸŸĐ rtx2080            Pass: 100%/2   | Total: 26m 45s | Avg: 13m 22s | Max: 23m 22s | Hits:  94%/318   
    ðŸŸĐ jobs
      ðŸŸĐ Build              Pass: 100%/1   | Total:  3m 23s | Avg:  3m 23s | Max:  3m 23s | Hits:  89%/159   
      ðŸŸĐ Test               Pass: 100%/1   | Total: 23m 22s | Avg: 23m 22s | Max: 23m 22s | Hits:  98%/159   
    

👃 Inspect Changes

Modifications in project?

Project
CCCL Infrastructure
+/- libcu++
CUB
Thrust
CUDA Experimental
stdpar
python
CCCL C Parallel Library
Catch2Helper

Modifications in project or dependencies?

Project
CCCL Infrastructure
+/- libcu++
+/- CUB
+/- Thrust
+/- CUDA Experimental
+/- stdpar
+/- python
+/- CCCL C Parallel Library
+/- Catch2Helper

🏃‍ Runner counts (total jobs: 174)

# Runner
123 linux-amd64-cpu16
15 windows-amd64-cpu16
12 linux-arm64-cpu16
10 linux-amd64-gpu-rtx2080-latest-1
6 linux-amd64-gpu-rtxa6000-latest-1
5 linux-amd64-gpu-h100-latest-1
3 linux-amd64-gpu-rtx4090-latest-1

@miscco
miscco merged commit 65040b8 into NVIDIA:main Apr 17, 2025
@github-project-automation github-project-automation Bot moved this from In Review to Done in CCCL Apr 17, 2025
_CCCL_ASSERT(__cnt != numeric_limits<int>::min(), "__cnt overflow");
return _CUDA_VSTD::__rotl(__t, -__cnt);
// todo: replace with cuda::__neg when available
__cnt = static_cast<int>((~static_cast<unsigned>(__cnt) + 1) % numeric_limits<_Tp>::digits);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if I'm understanding this change correctly. INT_MIN is undefined behavior and we could use an assertion here. Using the negation with INT_MIN , the result will be 2 which is weird.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, it is not an undefined behaviour :) The standard describes those functions as (example for rotl:

  • In the following descriptions, let N denote numeric_limits<T>​::​digits

template<class T> constexpr T rotl(T x, int s) noexcept;

  • Let r be s % N
  • Returns: If r is 0, x; if r is positive, (x << r) | (x >> (N - r)); if r is negative, rotr(x, -r)

The fact that they define the temporary r makes all of the operations well defined.

Note that -r is passed to rotr, not -s.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't check the standard to be honest 😅
it seems that for __cnt < 0 we are applying modulo twice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants