Repository navigation
Fix issue where calling merge_sort on custom types was failing - #4367
Merged
Merged
Conversation
âĶpatching merge sort. This was causing the merge sort custom types test to fail
shwina
approved these changes
Apr 7, 2025
Contributor
ðĐ CI finished in 1h 34m: Pass: 100%/101 | Total: 2d 23h | Avg: 42m 37s | Max: 1h 31m | Hits: 78%/140297
|
| Project | |
|---|---|
| CCCL Infrastructure | |
| libcu++ | |
| +/- | CUB |
| Thrust | |
| CUDA Experimental | |
| stdpar | |
| +/- | python |
| +/- | CCCL C Parallel Library |
| Catch2Helper |
Modifications in project or dependencies?
| Project | |
|---|---|
| CCCL Infrastructure | |
| libcu++ | |
| +/- | CUB |
| +/- | Thrust |
| CUDA Experimental | |
| +/- | stdpar |
| +/- | python |
| +/- | CCCL C Parallel Library |
| +/- | Catch2Helper |
ðâ Runner counts (total jobs: 101)
| # | Runner |
|---|---|
| 72 | linux-amd64-cpu16 |
| 9 | windows-amd64-cpu16 |
| 6 | linux-arm64-cpu16 |
| 6 | linux-amd64-gpu-rtxa6000-latest-1 |
| 3 | linux-amd64-gpu-h100-latest-1 |
| 3 | linux-amd64-gpu-rtx4090-latest-1 |
| 2 | linux-amd64-gpu-rtx2080-latest-1 |
oleksandr-pavlyk
approved these changes
Apr 8, 2025
oleksandr-pavlyk
left a comment
Contributor
There was a problem hiding this comment.
Just curious how you discovered this? Perhaps we should run cccl/c/parallel test suite from under compute-sanitizer.
Contributor
Author
@shwina reported the issue. Coincidentally I noticed that we were using the wrong key and value sizes while working on radix_sort, so I checked the existing algorithms to see where else we were doing that. Fixing it in merge_sort fixed this issue.
I would definitely support that |
elstehle
approved these changes
Apr 8, 2025
2 tasks done
davebayer
pushed a commit
to davebayer/cccl
that referenced
this pull request
Apr 11, 2025
âĶpatching merge sort. This was causing the merge sort custom types test to fail for larger sizes (NVIDIA#4367)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
closes #4240
Checklist