Repository navigation
fix: normalize criteria serialization keys to lowercase with omitempty - #2961
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Important Review skippedReview was skipped as selected files did not have any reviewable changes. âïļ Run configurationConfiguration used: Repository: NVIDIA/aicr/.coderabbit.yaml Review profile: ASSERTIVE Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. ð âđïļ Recent review infoâïļ Run configurationConfiguration used: Repository: NVIDIA/aicr/.coderabbit.yaml Review profile: ASSERTIVE Plan: Enterprise Run ID: ð Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review. ð WalkthroughWalkthroughThe Priority: â Normal Estimated code review effort: 2 (Simple) | ~8 minutes Change: Bug fix · Severity of issue fixed: Medium Suggested reviewers: Merge Risk: ⊠Minimal · up to The CLI output change matches the documented example and inspected in-repository consumers. No confirmed issue blocks merging. ðĨ Pre-merge checks | â 4â Passed checks (4 passed)
âĻ Finishing Touchesð§Š Generate unit tests (beta)
Comment |
Recipe evidence checkNo leaf overlays affected by this PR. This gate is warning-only and never blocks merge. |
|
ðŋ Preview your docs: https://nvidia-preview-fix-criteria-serialization-keys.docs.buildwithfern.com/aicr |
Fixes #2897
Root cause:
pkg/client/v1.Criteriahad nojson/yamlstruct tags.encoding/jsonfell back to Go exported field names (Service,OS,Nodes);yaml.v3auto-lowercased. Consumers switching formats, or pipingrecipe list --format jsonintojq '.[].criteria.service', gotnull.Fix:
json:"field,omitempty" yaml:"field,omitempty"tags to all six fields onCriteriainpkg/client/v1/types.go["Service"]assertion inpkg/cli/recipe_list_test.goto["service"]Tested:
go test ./pkg/client/v1/...andgo test ./pkg/cli/...pass.