Skip to content

fix: Update Automodel integration check logic and message. - #981

Merged
terrykong merged 4 commits into
mainfrom
ffrujeri/automodel_integration_check
Aug 26, 2025
Merged

fix: Update Automodel integration check logic and message.#981
terrykong merged 4 commits into
mainfrom
ffrujeri/automodel_integration_check

Conversation

@ffrujeri

Copy link
Copy Markdown
Contributor

What does this PR do ?

Update Automodel integration check logic and message.

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you run the unit tests and functional tests locally? Visit our Testing Guide for how to run tests
  • Did you add or update any necessary documentation? Visit our Document Development Guide for how to write, build and test the docs.

Additional Information

  • ...

Signed-off-by: Felipe Vieira Frujeri <ffrujeri@nvidia.com>
@github-actions github-actions Bot added the CI Relating to CI label Aug 25, 2025
Signed-off-by: Felipe Vieira Frujeri <ffrujeri@nvidia.com>
@github-actions

Copy link
Copy Markdown

⚠️ File Synchronization Check

Check based on commit: 54a8af4 (PR #981 from ffrujeri/automodel_integration_check)

⚠️ Parallel Plans Synchronization Warning

The file nemo_rl/models/dtensor/parallelize.py was modified in this PR, but neither 3rdparty/Automodel-workspace/Automodel/nemo_automodel/components/distributed/optimized_tp_plans.py nor 3rdparty/Automodel-workspace/Automodel/nemo_automodel/components/distributed/parallelizer.py was updated.

Why this matters:
These files contain similar parallel plan implementations that should be kept synchronized to ensure consistency across the codebase.

Action required:

  • Please review if the changes in nemo_rl/models/dtensor/parallelize.py should also be applied to 3rdparty/Automodel-workspace/Automodel/nemo_automodel/components/distributed/optimized_tp_plans.py or 3rdparty/Automodel-workspace/Automodel/nemo_automodel/components/distributed/parallelizer.py
  • Update the appropriate related file(s) if necessary to maintain synchronization
  • Request access to the NVIDIA-NeMo/Automodel repository, create a PR against the nemo-rl-submodule branch, and update the Automodel submodule in the nemo-rl index
  • Add @ffrujeri as a reviewer of this PR if you have any questions about the synchronization requirements
  • If the files are intentionally different, please add a comment in the PR explaining why

Files to check:

  • Modified: nemo_rl/models/dtensor/parallelize.py
  • Not modified: 3rdparty/Automodel-workspace/Automodel/nemo_automodel/components/distributed/optimized_tp_plans.py
  • Not modified: 3rdparty/Automodel-workspace/Automodel/nemo_automodel/components/distributed/parallelizer.py

This check ensures that related file implementations remain synchronized across the codebase. If you believe this warning is incorrect or the files should intentionally differ, please add a comment explaining the reasoning.

Signed-off-by: Felipe Vieira Frujeri <ffrujeri@nvidia.com>
Signed-off-by: Felipe Vieira Frujeri <ffrujeri@nvidia.com>
@terrykong
terrykong enabled auto-merge August 25, 2025 23:41
@terrykong
terrykong added this pull request to the merge queue Aug 25, 2025
github-merge-queue Bot pushed a commit that referenced this pull request Aug 25, 2025
Signed-off-by: Felipe Vieira Frujeri <ffrujeri@nvidia.com>
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Aug 26, 2025
@terrykong
terrykong added this pull request to the merge queue Aug 26, 2025
Merged via the queue into main with commit 8d8f365 Aug 26, 2025
21 checks passed
@terrykong
terrykong deleted the ffrujeri/automodel_integration_check branch August 26, 2025 14:40
jveronvialard pushed a commit that referenced this pull request Aug 27, 2025
Signed-off-by: Felipe Vieira Frujeri <ffrujeri@nvidia.com>
Signed-off-by: Julien Veron Vialard <jveronvialar@nvidia.com>
soodoshll pushed a commit to soodoshll/RL that referenced this pull request Aug 28, 2025
…Mo#981)

Signed-off-by: Felipe Vieira Frujeri <ffrujeri@nvidia.com>
Signed-off-by: Qidong Su <qidongs@nvidia.com>
skirdey-inflection pushed a commit to skirdey-inflection/RL that referenced this pull request Aug 30, 2025
…Mo#981)

Signed-off-by: Felipe Vieira Frujeri <ffrujeri@nvidia.com>
Signed-off-by: Stanislav Kirdey <stan@inflection.ai>
soodoshll pushed a commit to soodoshll/RL that referenced this pull request Sep 4, 2025
…Mo#981)

Signed-off-by: Felipe Vieira Frujeri <ffrujeri@nvidia.com>
Signed-off-by: Qidong Su <qidongs@nvidia.com>
PrinsYin pushed a commit to PrinsYin/RL that referenced this pull request Nov 30, 2025
…Mo#981)

Signed-off-by: Felipe Vieira Frujeri <ffrujeri@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Relating to CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants