feat: add throughput/prompt_length/total_num_tokens metrics - #781
Merged
Conversation
Signed-off-by: Zhiyu Li <zhiyul@nvidia.com>
ZhiyuLi-Nvidia
requested review from
SahilJain314,
parthchadha and
terrykong
and removed request for
parthchadha
July 29, 2025 08:07
parthchadha
reviewed
Jul 29, 2025
Contributor
Author
|
@terrykong @SahilJain314 could you take a look? |
parthchadha
reviewed
Jul 30, 2025
terrykong
reviewed
Jul 30, 2025
Signed-off-by: Zhiyu Li <zhiyul@NVIDIA.com>
ZhiyuLi-Nvidia
force-pushed
the
zhiyul/add_throughput_metric
branch
from
July 31, 2025 22:00
345388b to
707a7d2
Compare
parthchadha
approved these changes
Aug 1, 2025
terrykong
added this pull request to the merge queue
Aug 1, 2025
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Aug 1, 2025
terrykong
added this pull request to the merge queue
Aug 1, 2025
tpoisonooo
pushed a commit
to tpoisonooo/RL
that referenced
this pull request
Aug 4, 2025
âĶeMo#781) Signed-off-by: Zhiyu Li <zhiyul@nvidia.com> Signed-off-by: Zhiyu Li <zhiyul@NVIDIA.com> Signed-off-by: tpoisonooo <khj.application@aliyun.com>
soodoshll
pushed a commit
to soodoshll/RL
that referenced
this pull request
Aug 13, 2025
âĶeMo#781) Signed-off-by: Zhiyu Li <zhiyul@nvidia.com> Signed-off-by: Zhiyu Li <zhiyul@NVIDIA.com> Signed-off-by: Qidong Su <qidongs@nvidia.com>
PrinsYin
pushed a commit
to PrinsYin/RL
that referenced
this pull request
Nov 30, 2025
âĶeMo#781) Signed-off-by: Zhiyu Li <zhiyul@nvidia.com> Signed-off-by: Zhiyu Li <zhiyul@NVIDIA.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
As attached. Add the following metrics:
https://wandb.ai/nvidia/grpo-dev/runs/33pb40kk?nw=nwuserzhiyul
As a quick verification/test:
Issues
List issues that this PR closes (syntax):
Usage
# Add a code snippet demonstrating how to use thisBefore your PR is "Ready for review"
Pre checks:
Additional Information