Skip to content

build: Bump python to 3.12.12 and mlflow to 3.5.1 - #1482

Merged
terrykong merged 2 commits into
mainfrom
chtruong/bump-deps
Nov 7, 2025
Merged

build: Bump python to 3.12.12 and mlflow to 3.5.1#1482
terrykong merged 2 commits into
mainfrom
chtruong/bump-deps

Conversation

@chtruong814

@chtruong814 chtruong814 commented Nov 6, 2025

Copy link
Copy Markdown
Contributor

What does this PR do ?

Bump python to 3.12.12 and mlflow to 3.5.1. The uv version needs to be updated to install the newer python.

Issues

List issues that this PR closes (syntax):

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you run the unit tests and functional tests locally? Visit our Testing Guide for how to run tests
  • Did you add or update any necessary documentation? Visit our Document Development Guide for how to write, build and test the docs.

Additional Information

  • ...

Summary by CodeRabbit

  • Chores
    • Updated build tool version to 0.9.7 in Docker configurations.
    • Added version constraints to mlflow dependency (3.5.0-3.6.0).

Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
@chtruong814
chtruong814 requested review from a team as code owners November 6, 2025 19:00
@chtruong814 chtruong814 added r0.4.0 CI:L1 Run doctests, unit tests, and functional tests labels Nov 6, 2025
@chtruong814 chtruong814 changed the title Bump python to 3.12.12 and mlflow to 3.5.1 build: Bump python to 3.12.12 and mlflow to 3.5.1 Nov 6, 2025
@coderabbitai

coderabbitai Bot commented Nov 6, 2025

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

Three dependency and tool versions are updated across configuration files: UV installation tool upgraded from 0.9.1 to 0.9.7 in both Dockerfiles, and mlflow dependency pinned to version range >=3.5.0,<3.6.0 in pyproject.toml. No logic or control-flow changes.

Changes

Cohort / File(s) Summary
Docker UV version updates
docker/Dockerfile, docker/Dockerfile.ngc_pytorch
UV_VERSION argument updated from 0.9.1 to 0.9.7, changing the uv installer tool version fetched during image build
Python dependency pinning
pyproject.toml
mlflow dependency constrained from unbounded to version range >=3.5.0,<3.6.0

Estimated code review effort

ðŸŽŊ 2 (Simple) | ⏱ïļ ~8 minutes

  • All changes are routine version/dependency updates with no logic modifications
  • Two identical and repetitive UV version updates across Dockerfiles require minimal per-file reasoning
  • mlflow version pinning is a straightforward constraint specification with no side effects to verify

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Test Results For Major Changes ⚠ïļ Warning PR constrains MLflow to >=3.5.0,<3.6.0 and updates dependencies, but the PR description lacks test results, compatibility verification, or evidence of regression testing. Update PR description with confirmation that all tests pass with Python 3.12.12 and MLflow 3.5.x, document compatibility testing, and verify no regressions in model tracking.
Title check ⚠ïļ Warning The title mentions bumping Python to 3.12.12 and mlflow to 3.5.1, but the actual changes show mlflow pinned to 3.5.0-3.6.0 range (not 3.5.1 specifically), and no Python version changes are visible in the provided changeset. Update the title to accurately reflect the actual changes: 'Update UV to 0.9.7 and pin mlflow to 3.5.0-3.6.0' or clarify if Python version changes are in separate files not shown in this summary.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
âœĻ Finishing touches
  • 📝 Generate docstrings
🧊 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chtruong/bump-deps

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

âĪïļ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@terrykong
terrykong merged commit 82bf15a into main Nov 7, 2025
56 of 60 checks passed
@terrykong
terrykong deleted the chtruong/bump-deps branch November 7, 2025 05:59
chtruong814 added a commit that referenced this pull request Nov 7, 2025
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
terrykong pushed a commit that referenced this pull request Nov 8, 2025
#1489)

Signed-off-by: Charlie Truong <chtruong@nvidia.com>
PrinsYin pushed a commit to PrinsYin/RL that referenced this pull request Nov 30, 2025
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
DeL-TaiseiOzaki pushed a commit to DeL-TaiseiOzaki/RL that referenced this pull request Jan 8, 2026
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
yuanhangsu1986 pushed a commit to yuanhangsu1986/RL-Nemontron-Edge-Omni that referenced this pull request Feb 21, 2026
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: yuanhangs <yuanhangs@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI:L1 Run doctests, unit tests, and functional tests r0.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants