Skip to content

cp: fix: Reinitialize model parallel after import (1317) into r0.4.0 - #1428

Merged
terrykong merged 1 commit into
r0.4.0from
cherry-pick-1317-r0.4.0
Oct 28, 2025
Merged

cp: fix: Reinitialize model parallel after import (1317) into r0.4.0#1428
terrykong merged 1 commit into
r0.4.0from
cherry-pick-1317-r0.4.0

Conversation

@zpqiu

@zpqiu zpqiu commented Oct 27, 2025

Copy link
Copy Markdown
Contributor

(cherry picked from commit d726c38)

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Issues

List issues that this PR closes (syntax):

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you run the unit tests and functional tests locally? Visit our Testing Guide for how to run tests
  • Did you add or update any necessary documentation? Visit our Document Development Guide for how to write, build and test the docs.

Additional Information

  • ...

Signed-off-by: Yubo Gao <yubog@nvidia.com>
(cherry picked from commit d726c38)
@zpqiu
zpqiu requested a review from a team as a code owner October 27, 2025 07:07
@zpqiu zpqiu added the CI:L1 Run doctests, unit tests, and functional tests label Oct 27, 2025
@zpqiu zpqiu added the Run CICD label Oct 27, 2025
@zpqiu zpqiu changed the title cp: fix: Reinitialize model parallel after import (1317) into r0.4.0 cp: fix: Reinitialize model parallel after import (1317) into r0.4.0 Oct 27, 2025
@zpqiu
zpqiu requested a review from terrykong October 27, 2025 11:25
@zpqiu

zpqiu commented Oct 27, 2025

Copy link
Copy Markdown
Contributor Author

@terrykong , the CI passed https://github.com/NVIDIA-NeMo/RL/actions/runs/18832766122/job/53741045252, but didn't know why it wasn't shown on UI.

@terrykong
terrykong enabled auto-merge (squash) October 27, 2025 16:37
@terrykong terrykong added CI:L1 Run doctests, unit tests, and functional tests and removed CI:L1 Run doctests, unit tests, and functional tests labels Oct 27, 2025
@terrykong

Copy link
Copy Markdown
Collaborator

@zpqiu weird. restarting now

@terrykong
terrykong merged commit 09c92ea into r0.4.0 Oct 28, 2025
99 of 104 checks passed
@terrykong
terrykong deleted the cherry-pick-1317-r0.4.0 branch October 28, 2025 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-pick CI:L1 Run doctests, unit tests, and functional tests Run CICD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants