Skip to content

Loosen modifier benchmark - #2321

Merged
sarahyurick merged 1 commit into
NVIDIA-NeMo:mainfrom
sarahyurick:modifier_benchmark_update
Aug 19, 2026
Merged

sarahyurick merged 1 commit into
NVIDIA-NeMo:mainfrom
sarahyurick:modifier_benchmark_update

Conversation

@sarahyurick

Copy link
Copy Markdown
Contributor

No description provided.

Signed-off-by: Sarah Yurick <sarahyurick@gmail.com>
@sarahyurick
sarahyurick requested a review from a team as a code owner August 19, 2026 15:53
@sarahyurick
sarahyurick requested review from VibhuJawa and removed request for a team August 19, 2026 15:53
@sarahyurick
sarahyurick enabled auto-merge (squash) August 19, 2026 15:53
@sarahyurick
sarahyurick requested a review from rlratzel August 19, 2026 15:54
@greptile-apps

greptile-apps Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR loosens the nightly modifier Ray Data benchmark’s throughput requirement.

  • Lowers the minimum accepted throughput from 60,000 to 55,000 documents per second.
  • Leaves the benchmark configuration and execution behavior otherwise unchanged.

Confidence Score: 5/5

The PR appears safe to merge because the only change is the intentional relaxation of a benchmark acceptance threshold.

The benchmark harness will accept modifier Ray Data throughput at or above 55,000 documents per second as intended, with no production runtime behavior affected.

Important Files Changed

Filename Overview
benchmarking/nightly-benchmark.yaml Intentionally reduces the modifier Ray Data benchmark’s minimum throughput threshold; no actionable defect identified.

Reviews (1): Last reviewed commit: "Loosen modifier benchmark" | Re-trigger Greptile

@sarahyurick
sarahyurick merged commit 9c56211 into NVIDIA-NeMo:main Aug 19, 2026
100 of 106 checks passed
tromanski-nv pushed a commit to tromanski-nv/Curator that referenced this pull request Sep 14, 2026
Signed-off-by: Sarah Yurick <sarahyurick@gmail.com>

This branch was successfully deployed

2 inactive deployments
nemo-ci — 9dc6b1bf Deployed Aug 19, 2026 by copy-pr-bot[bot] via Unit_Test_stages-audio_CPU #5282
public — 9dc6b1bf Deployed Aug 19, 2026 by copy-pr-bot[bot] via release / finalize / notify #853
test — 9dc6b1bf Deployed Aug 19, 2026 by copy-pr-bot[bot] via cicd-wait-in-queue #5282
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants