Repository navigation
Fix valid slide part list being corrupted when using mirror mod - #476
Merged
Merged
Conversation
LumpBloom7
force-pushed
the
fix-slide-mirror-corruption
branch
from
August 12, 2023 23:38
b05d5d9 to
0a17adf
Compare
Structs are still copy on write, so modifying without ref vars only affected the local copy in the loop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SlidePathsprecomputes a bunch of valid paths parts to be used in beatmap conversions. The converted maps will use the parts when creating slides.The mirrored mod would then adjust the
EndOffsetandMirroredproperties so that it actually gets mirrored.The problem is that
SlideBodyPartis a class, which meant that adjustments to a part's properties that will affect the original copy within the valid path listing, causing problems in future map conversions.Now
SlideBodyPartis a struct, which is copy-on-use, avoiding the problem.